Merge pull request aframevr#3847 from ngokevin/soundfix

fix sound component playSound on event (fixes aframevr#3844)

Author: ngokevin

src/components/sound.js

@@ -1,6 +1,5 @@
 var registerComponent = require('../core/component').registerComponent;
 var debug = require('../utils/debug');
-var bind = require('../utils/bind');
 var THREE = require('../lib/three');
 
 var warn = debug('components:sound:warn');
@@ -31,7 +30,9 @@ module.exports.Component = registerComponent('sound', {
     this.pool = new THREE.Group();
     this.loaded = false;
     this.mustPlay = false;
-    this.playSound = bind(this.playSound, this);
+
+    // Don't pass evt because playSound takes a function as parameter.
+    this.playSoundBound = () => { this.playSound(); };
   },
 
   update: function (oldData) {
@@ -119,12 +120,12 @@ module.exports.Component = registerComponent('sound', {
   */
   updateEventListener: function (oldEvt) {
     var el = this.el;
-    if (oldEvt) { el.removeEventListener(oldEvt, this.playSound); }
-    el.addEventListener(this.data.on, this.playSound);
+    if (oldEvt) { el.removeEventListener(oldEvt, this.playSoundBound); }
+    el.addEventListener(this.data.on, this.playSoundBound);
   },
 
   removeEventListener: function () {
-    this.el.removeEventListener(this.data.on, this.playSound);
+    this.el.removeEventListener(this.data.on, this.playSoundBound);
   },
 
   /**

tests/components/sound.test.js

@@ -186,6 +186,17 @@ suite('sound', function () {
       el.setAttribute('sound', 'src', 'url(base/tests/assets/test.ogg)');
       el.components.sound.isPlaying = true;
     });
+
+    test('plays sound on event', function (done) {
+      const el = this.el;
+      el.setAttribute('sound', 'on', 'foo');
+      const playSoundStub = el.components.sound.playSound = sinon.stub();
+      el.emit('foo');
+      setTimeout(() => {
+        assert.ok(playSoundStub.called);
+        done();
+      });
+    });
   });
 
   suite('stopSound', function () {