[PFI-1019] Add groups to the "list all collections" api responses #6524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kspearrin
commented
Oct 30, 2025
| _currentContext.OrganizationId.Value); | ||
| // TODO: Get all CollectionGroup associations for the organization and marry them up here for the response. | ||
| var collectionResponses = collections.Select(c => new CollectionResponseModel(c, null)); | ||
| // TODO: Do we need to filter out DefaultUserCollection types here like we do in Get above? |
There was a problem hiding this comment.
_collectionRepository.GetManySharedCollectionsByOrganizationIdAsync already filters out DefaultUserCollection types.
You're right that if we use GetManyByOrganizationIdWithAccessAsync then we need to filter it out here
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6524 +/- ##
=======================================
Coverage 51.86% 51.86%
=======================================
Files 1902 1902
Lines 84058 84058
Branches 7501 7501
=======================================
Hits 43598 43598
Misses 38766 38766
Partials 1694 1694 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PFI-1019
📔 Objective
Group information was missing on collection object returned from
GET /public/collectionsAPI. Added it in using data on thecollectionRepository.GetManyByOrganizationIdWithAccessAsync()query.