-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
chore: replace css-color-converter with color
#11264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's a good idea to migrate, please consider starting a discussion prior to a PR next time, just to avoid a situation where a done PR is not accepted as a discussion might not result in accepting a migration.
The code looks good, but seems the old package was not removed.
Once removed I will run some tests and we can make a release.
3ed1772 to
c5398ec
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
c5398ec to
cf3f31f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note changes proposed at LitoMore#1088
Also, while testing it appears hwb in static badge is black for any color.
cf3f31f to
ce5097d
Compare
|
Thanks for catching the issue. I also noticed the upstream library |
|
This is arguably a performance-sensitive part of our codebase, as it impacts the rendering of all badges. It would be great to do some quick performance analysis to make sure we aren't introducing overhead with the new library. :) |
|
Just wanted to add to my previous message: we do have some simple things in place to do micro-benchmarks, see this page in our docs! |
It looks like the
css-color-converteris lacking maintenance. Here I replaced thecss-color-converterwith thecolorlibrary. Thecolorlibrary is pure ESM and more modern.I'm also the maintainer of the
colorprojects (color,color-convert,color-string). And the author of thecolorproject Qix- is also the maintainer of the most popular ANSI color library - Chalk.Here are some slight differences between
colorandcss-color-converter:colorcss-color-converterI've updated the documentation for the new HWB support.
There are some unrelated changes because Prettier reported some code style problems while running
npm test. I've fixed them withnpx pretter --write ..