Skip to content

Commit f3a3b6c

Browse files
authored
remove arbitrary response read timeout in kinesis GetRecords (#3221)
1 parent 56af155 commit f3a3b6c

File tree

8 files changed

+21
-66
lines changed

8 files changed

+21
-66
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"id": "1f03d280-f303-49f1-822b-03d3e6a29fec",
3+
"type": "bugfix",
4+
"description": "Deprecate http.AddResponseReadTimeoutMiddleware.",
5+
"modules": [
6+
"."
7+
]
8+
}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
{
2+
"id": "8cb021f3-ad79-4653-afac-4d9b2d23827f",
3+
"type": "bugfix",
4+
"description": "Remove arbitrary read timeout on GetRecords which was causing response read panic. See #2752.",
5+
"modules": [
6+
"service/kinesis"
7+
]
8+
}

‎aws/transport/http/timeout_read_closer.go‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,11 @@ func (r *timeoutReadCloser) Close() error {
6464

6565
// AddResponseReadTimeoutMiddleware adds a middleware to the stack that wraps the
6666
// response body so that a read that takes too long will return an error.
67+
//
68+
// Deprecated: This API was previously exposed to customize behavior of the
69+
// Kinesis service. That customization has been removed and this middleware's
70+
// implementation can cause panics within the standard library networking loop.
71+
// See #2752.
6772
func AddResponseReadTimeoutMiddleware(stack *middleware.Stack, duration time.Duration) error {
6873
return stack.Deserialize.Add(&readTimeout{duration: duration}, middleware.After)
6974
}

‎codegen/smithy-aws-go-codegen/src/main/java/software/amazon/smithy/aws/go/codegen/customization/service/kinesis/KinesisCustomizations.java‎

Lines changed: 0 additions & 51 deletions
This file was deleted.

‎codegen/smithy-aws-go-codegen/src/main/resources/META-INF/services/software.amazon.smithy.go.codegen.integration.GoIntegration‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ software.amazon.smithy.aws.go.codegen.customization.service.s3.S3ContentSHA256He
3232
software.amazon.smithy.aws.go.codegen.customization.service.s3.BackfillS3ObjectSizeMemberShapeType
3333
software.amazon.smithy.aws.go.codegen.customization.service.machinelearning.MachineLearningCustomizations
3434
software.amazon.smithy.aws.go.codegen.customization.service.s3.S3AcceptEncodingGzip
35-
software.amazon.smithy.aws.go.codegen.customization.service.kinesis.KinesisCustomizations
3635
software.amazon.smithy.aws.go.codegen.customization.service.s3.S3ErrorWith200Status
3736
software.amazon.smithy.aws.go.codegen.customization.service.route53.Route53Customizations
3837
software.amazon.smithy.aws.go.codegen.customization.PresignURLAutoFill

‎service/kinesis/api_op_GetRecords.go‎

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎service/kinesis/internal/customizations/readtimeout.go‎

Lines changed: 0 additions & 8 deletions
This file was deleted.

‎service/kinesis/snapshot/api_op_GetRecords.go.snap‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,5 @@ GetRecords
4848
InterceptBeforeDeserialization
4949
AddTimeOffsetMiddleware
5050
RecordResponseTiming
51-
ReadResponseTimeout
5251
RequestResponseLogger
5352
InterceptTransmit

0 commit comments

Comments
 (0)