Skip to content

fix(ui): add null-safe handling for assignedWindows in status panel #25128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ui): add null-safe handling for assignedWindows in status panel #25128

wants to merge 1 commit into from
+5 −3

Conversation

@choejwoo
Copy link
Contributor

Closes #22786

Hello, I checked this issue and found that the problem occurs when the assignedWindows reference is unavailable.
After reviewing the code, I identified the parts where assignedWindows is being accessed and manually injected a null value to confirm that an error occurs when it’s referenced.

Without null-safe handling

null_guard_assignedWindows

Since assignedWindows is used only in a few places, I added null-safe handling where applicable.
After adding the null-safe handling, I tested again by forcing a null value, and confirmed that the UI loaded properly without any errors.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
@choejwoo
fix(ui): add null-safe guard for assignedWindows
9a865fc 
Signed-off-by: choejwoo <jaewoo45@gmail.com>
@choejwoo choejwoo requested a review from a team as a code owner October 31, 2025 06:57
@bunnyshell
Copy link

bunnyshell bot commented Oct 31, 2025 •
edited
Loading

❗ Preview Environment deployment failed on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🚀 /bns:deploy to redeploy the environment
  • ❌ /bns:delete to remove the environment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@choejwoo @rumstead