fix(appset): ensure finalizer is added when deletionOrder is set as reverse #25125
+230
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sisted-by: claude-code Signed-off-by: Kanika Rana <krana@redhat.com>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
ranakan19
commented
Oct 30, 2025
| if err := r.Update(ctx, &applicationSetInfo); err != nil { | ||
| return ctrl.Result{}, err | ||
| } | ||
| return ctrl.Result{}, nil |
There was a problem hiding this comment.
we can likely remove this - updating the annotations would already reconcile Appset again - so explicit reconcile has no real effect.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25125 +/- ##
=========================================
Coverage ? 62.34%
=========================================
Files ? 351
Lines ? 49219
Branches ? 0
=========================================
Hits ? 30688
Misses ? 15595
Partials ? 2936 ☔ View full report in Codecov by Sentry. |
nitishfy
reviewed
Oct 31, 2025
Signed-off-by: Kanika Rana <krana@redhat.com>
nitishfy
reviewed
Oct 31, 2025
| **Important:** The ApplicationSet finalizer is not removed until all applications are successfully deleted. This ensures proper cleanup and prevents the ApplicationSet from being removed before its managed applications. | ||
| **Important:** The ApplicationSet finalizer is not removed until all applications are successfully deleted. This ensures proper cleanup and prevents the ApplicationSet from being removed before its managed applications. | ||
|
|
||
| **Note:** ApplicationSet controller ensures there is a finalizer when deletionOrder is set as Reverse with progressive sync enabled. That is - if the applicationset is missing the required finalizer, the controller adds the finalizer to ApplicationSet before generating applications. |
There was a problem hiding this comment.
Suggested change
| **Note:** ApplicationSet controller ensures there is a finalizer when deletionOrder is set as Reverse with progressive sync enabled. That is - if the applicationset is missing the required finalizer, the controller adds the finalizer to ApplicationSet before generating applications. | |
| **Note:** ApplicationSet controller ensures there is a finalizer when `deletionOrder` is set as `Reverse` with progressive sync enabled. This means that if the applicationset is missing the required finalizer, the applicationset controller adds the finalizer to ApplicationSet before generating applications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25105
Checklist: