Skip to content

Conversation

@willrnt
Copy link

@willrnt willrnt commented Oct 30, 2025

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
Signed-off-by: willrnt <billyrnt@outlook.com>
@willrnt willrnt requested review from a team as code owners October 30, 2025 03:19
@bunnyshell
Copy link

bunnyshell bot commented Oct 30, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment
Signed-off-by: willrnt <billyrnt@outlook.com>
@willrnt willrnt changed the title Add Cloud Provider Air Gap Note to declarative-setup.md Oct 30, 2025
@willrnt willrnt changed the title Docs: Add Cloud Provider Air Gap Note to declarative-setup.md Oct 30, 2025
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generalize this a bit? Instead of saying specifically what to trust or not trust, it seems like we could say something like "You can add custom certificates by doing X"

Signed-off-by: willrnt <billyrnt@outlook.com>
@willrnt
Copy link
Author

willrnt commented Oct 31, 2025

Thanks @todaywasawesome! Please let me know your thought on the new message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants