-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: add Redis cluster mode support (Alpha) #25115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Mohamed Elawadi <mohamed@elawadi.net>
Signed-off-by: Mohamed Elawadi <mohamed@elawadi.net>
Signed-off-by: Mohamed Elawadi <mohamed@elawadi.net>
Signed-off-by: Mohamed Elawadi <mohamed@elawadi.net>
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
…ter mode Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…rs for Redis cluster mode Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
c14e4d4 to
b1ce8b5
Compare
Signed-off-by: Frederic Mereu <frederic.mereu@gaming1.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…havior (argoproj#25024) Signed-off-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: shota3506 <s.shota.710.3506@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…rgoproj#24717) Signed-off-by: choejwoo <jaewoo45@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…dd08f76 (argoproj#25073) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
…proj#25086) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com>
…rgoproj#25099) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
…roj#25068) Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Yusuke Abe <chansuke0@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…#22706) Signed-off-by: Afzal Ansari <afzal442@gmail.com>
ff1901a to
5258c09
Compare
Signed-off-by: Frederic Mereu <frederic.mereu@gaming1.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…proj#25086) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…rgoproj#25099) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
…roj#25068) Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Yusuke Abe <chansuke0@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…#22706) Signed-off-by: Afzal Ansari <afzal442@gmail.com>
5258c09 to
37af32a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25115 +/- ##
==========================================
- Coverage 62.29% 62.18% -0.11%
==========================================
Files 351 351
Lines 49213 49253 +40
==========================================
- Hits 30656 30629 -27
- Misses 15640 15687 +47
- Partials 2917 2937 +20 ☔ View full report in Codecov by Sentry. |
0223acf to
a9d9eff
Compare
Signed-off-by: Frederic Mereu <frederic.mereu@gaming1.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…havior (argoproj#25024) Signed-off-by: Nitish Kumar <justnitish06@gmail.com> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Co-authored-by: Regina Voloshin <regina.voloshin@codefresh.io>
Signed-off-by: rumstead <37445536+rumstead@users.noreply.github.com>
Signed-off-by: shota3506 <s.shota.710.3506@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…rgoproj#24717) Signed-off-by: choejwoo <jaewoo45@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…dd08f76 (argoproj#25073) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…proj#25086) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oj#25085) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bac879 (argoproj#25091) Signed-off-by: renovate[bot] <renovate[bot]@users.noreply.github.com> Co-authored-by: argoproj-renovate[bot] <161757507+argoproj-renovate[bot]@users.noreply.github.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…rgoproj#25099) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
…roj#25068) Signed-off-by: Josh Soref <jsoref@gmail.com> Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Yusuke Abe <chansuke0@gmail.com>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Jonathan Winters <wintersjonathan0@gmail.com> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
…#22706) Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
a9d9eff to
599a1f7
Compare
|
Sorry about all the duplicate rebase commits—didn't want to risk any issues by dropping any from history, so please perform a squash merge if the PR is acceptable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you sign all your commits? I also think you might need to bring a cleaner commit history here, it makes these more difficult to review an introduces risk.
I suggest starting with a new branch and applying your changes there first so you can bring in a clean history.
This PR is a revival or PR #14001 that has gone stale due to lack of follow-up by the original PR contributor @mie00. I have applied the original PR changes, rebased against the master branch, and changed the new CLI parameter and environment variable names to be consistent with existing names.
To re-iterate, this PR adds support for Redis running in cluster mode by:
redis.UniversalClientinterface abstraction--redis-cluster-modeCLI parameter andREDIS_CLUSTER_MODEenvironment variable (true/false) to useredis.ClusterClientinstead ofredis.ClientREDIS_CLUSTER_MODEenvironment variable using theredis.cluster.modevalue in theargocd-cmd-params-cmConfigMapChecklist: