-
Notifications
You must be signed in to change notification settings - Fork 6.5k
feat: implement KEDA scaledJob health-checks #25106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
48ea5e3 to
c1bd4e7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25106 +/- ##
=========================================
Coverage ? 62.24%
=========================================
Files ? 351
Lines ? 49213
Branches ? 0
=========================================
Hits ? 30632
Misses ? 15655
Partials ? 2926 ☔ View full report in Codecov by Sentry. |
| elseif condition.status == "Unknown" and condition.type == "Ready" then | ||
| hs.message = condition.message | ||
| hs.status = "Degraded" | ||
| return hs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add another status check for condition.status == "True" and condition.type == "Paused" and set the status as Suspended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! And you're absolutely right! I will change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added Suspended
c9647ed to
ed966ce
Compare
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
ed966ce to
a3645e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR adds ArgoCD health status for KEDA ScaledJobs.
Checklist: