Skip to content

Conversation

@rickbrouwer
Copy link
Contributor

@rickbrouwer rickbrouwer commented Oct 28, 2025

This PR adds ArgoCD health status for KEDA ScaledJobs.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [n/a] The title of the PR states what changed and the related issues number (used for the release note).
  • [n/a] The title of the PR conforms to the Title of the PR
  • [n/a] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [n/a] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [n/a] Does this PR require documentation updates?
  • [n/a] I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [n/a] Optional. My organization is added to USERS.md.
  • [n/a] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
@bunnyshell
Copy link

bunnyshell bot commented Oct 28, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment
@rickbrouwer rickbrouwer force-pushed the scaledjob branch 2 times, most recently from 48ea5e3 to c1bd4e7 Compare October 28, 2025 17:37
@rickbrouwer rickbrouwer marked this pull request as ready for review October 28, 2025 18:02
@rickbrouwer rickbrouwer requested a review from a team as a code owner October 28, 2025 18:02
@codecov
Copy link

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@ef48aa9). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #25106   +/-   ##
=========================================
  Coverage          ?   62.24%           
=========================================
  Files             ?      351           
  Lines             ?    49213           
  Branches          ?        0           
=========================================
  Hits              ?    30632           
  Misses            ?    15655           
  Partials          ?     2926           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 13 to 19
elseif condition.status == "Unknown" and condition.type == "Ready" then
hs.message = condition.message
hs.status = "Degraded"
return hs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add another status check for condition.status == "True" and condition.type == "Paused" and set the status as Suspended?

Copy link
Contributor Author

@rickbrouwer rickbrouwer Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! And you're absolutely right! I will change it.

Copy link
Contributor Author

@rickbrouwer rickbrouwer Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Suspended

@rickbrouwer rickbrouwer force-pushed the scaledjob branch 3 times, most recently from c9647ed to ed966ce Compare October 30, 2025 08:19
Signed-off-by: Rick Brouwer <rickbrouwer@gmail.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev added the component:health-check Issue related to built-in Health Check customizations label Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:health-check Issue related to built-in Health Check customizations

4 participants