Skip to content

Conversation

@pjiang-dev
Copy link
Contributor

@pjiang-dev pjiang-dev commented Oct 24, 2025

fixes #18126

If Redis unavailable users who on a link to an app's resource will error:
Unable to load data: error getting cached app managed resources

Instead we can return an empty managedResource object. This way users will still be able to login and see app details ect.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).
@pjiang-dev pjiang-dev requested a review from a team as a code owner October 24, 2025 19:49
@bunnyshell
Copy link

bunnyshell bot commented Oct 24, 2025

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment
@codecov
Copy link

codecov bot commented Oct 24, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.26%. Comparing base (05ccc01) to head (f77f035).
⚠️ Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
server/application/application.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25072      +/-   ##
==========================================
+ Coverage   60.89%   62.26%   +1.37%     
==========================================
  Files         351      351              
  Lines       60489    49214   -11275     
==========================================
- Hits        36832    30643    -6189     
+ Misses      20736    15642    -5094     
- Partials     2921     2929       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nitishfy
Copy link
Member

also, you'd be required to run codegen since you updated the types.go file.

@pjiang-dev
Copy link
Contributor Author

@nitishfy types.go change was a wrong commit i added by mistake. I addressed the error message comment. PTAL again. Thanks

pjiang-dev and others added 3 commits October 31, 2025 10:41
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Peter Jiang <35584807+pjiang-dev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants