-
Notifications
You must be signed in to change notification settings - Fork 6.5k
fix: return empty instead of error if cache unavailable #25072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
🔴 Preview Environment stopped on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #25072 +/- ##
==========================================
+ Coverage 60.89% 62.26% +1.37%
==========================================
Files 351 351
Lines 60489 49214 -11275
==========================================
- Hits 36832 30643 -6189
+ Misses 20736 15642 -5094
- Partials 2921 2929 +8 ☔ View full report in Codecov by Sentry. |
|
also, you'd be required to run codegen since you updated the |
b87dfc4 to
f77f035
Compare
|
@nitishfy types.go change was a wrong commit i added by mistake. I addressed the error message comment. PTAL again. Thanks |
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Signed-off-by: Peter Jiang <peterjiang823@gmail.com>
Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com> Signed-off-by: Peter Jiang <35584807+pjiang-dev@users.noreply.github.com>
ab508b5 to
244ead6
Compare
fixes #18126
If Redis unavailable users who on a link to an app's resource will error:
Unable to load data: error getting cached app managed resourcesInstead we can return an empty managedResource object. This way users will still be able to login and see app details ect.
Checklist: