fix InstallGitLib

Author: unknown

arduino/libraries/librariesmanager/install.go

@@ -235,37 +235,28 @@ func (lm *LibrariesManager) InstallGitLib(gitURL string, overwrite bool) error {
 		WithField("git url", gitURL).
 		Trace("Installing library")
 
-	depth := 1
-	if ref != "" {
-		depth = 0
-	}
-	repo, err := git.PlainClone(installPath.String(), false, &git.CloneOptions{
-		URL:      gitURL,
-		Depth:    depth,
-		Progress: os.Stdout,
+	_, err = git.PlainClone(installPath.String(), false, &git.CloneOptions{
+		URL:           gitURL,
+		ReferenceName: plumbing.ReferenceName(ref),
 	})
 	if err != nil {
-		logrus.
-			WithError(err).
-			Warn("Cloning git repository")
-		return err
-	}
+		if err.Error() != "reference not found" {
+			return err
+		}
 
-	if ref != "" {
-		if h, err := repo.ResolveRevision(plumbing.Revision(ref)); err != nil {
-			logrus.
-				WithError(err).
-				Warnf("Resolving revision %s", ref)
+		// We did not find the requested reference, let's do a PlainClone and use
+		// "ResolveRevision" to find and checkout the requested revision
+		if repo, err := git.PlainClone(installPath.String(), false, &git.CloneOptions{
+			URL: gitURL,
+		}); err != nil {
+			return err
+		} else if h, err := repo.ResolveRevision(plumbing.Revision(ref)); err != nil {
 			return err
 		} else if w, err := repo.Worktree(); err != nil {
-			logrus.
-				WithError(err).
-				Warn("Finding worktree")
 			return err
-		} else if err := w.Checkout(&git.CheckoutOptions{Hash: plumbing.NewHash(h.String())}); err != nil {
-			logrus.
-				WithError(err).
-				Warnf("Checking out %s", h)
+		} else if err := w.Checkout(&git.CheckoutOptions{
+			Force: true, // workaround for: https://github.com/go-git/go-git/issues/1411
+			Hash:  plumbing.NewHash(h.String())}); err != nil {
 			return err
 		}
 	}