Patch form jasonab

http://code.google.com/p/hibernate-memcached/issues/detail?id=12
Findbugs and Eclipse warnings...

Author: raykrueger

pom.xml

@@ -101,19 +101,6 @@
                     <target>1.5</target>
                 </configuration>
             </plugin>
-            <plugin>
-                <artifactId>maven-eclipse-plugin</artifactId>
-                <configuration>
-                    <downloadSources>true</downloadSources>
-                </configuration>
-            </plugin>
-            <plugin>
-                <artifactId>maven-idea-plugin</artifactId>
-                <configuration>
-                    <downloadSources>true</downloadSources>
-                    <downloadJavadocs>false</downloadJavadocs>
-                </configuration>
-            </plugin>
             <plugin>
                 <artifactId>maven-assembly-plugin</artifactId>
                 <configuration>

src/main/java/com/googlecode/hibernate/memcached/MemcachedCache.java

@@ -107,11 +107,11 @@ private String dogpileTokenKey(String objectKey) {
 
     private Object memcacheGet(Object key) {
         String objectKey = toKey(key);
-        String dogpileKey = dogpileTokenKey(objectKey);
 
         Map<String, Object> multi;
 
         if (dogpilePreventionEnabled) {
+            String dogpileKey = dogpileTokenKey(objectKey);
             log.debug("Checking dogpile key: [{}]", dogpileKey);
 
             log.debug("Memcache.getMulti({}, {})", objectKey, dogpileKey);
@@ -121,9 +121,8 @@ private Object memcacheGet(Object key) {
                 log.debug("Dogpile key ({}) not found updating token and returning null", dogpileKey);
                 memcache.set(dogpileKey, cacheTimeSeconds, DOGPILE_TOKEN);
                 return null;
-            } else {
-                log.debug("Dogpile token found for key ({}), getting cached object", dogpileKey);
             }
+            log.debug("Dogpile token found for key ({}), getting cached object", dogpileKey);
         } else {
             log.debug("Memcache.get({})", objectKey);
             multi = memcache.getMulti(objectKey);
@@ -235,7 +234,7 @@ private long getClearIndex() {
             Object value = memcache.get(clearIndexKey);
             if (value != null) {
                 if (value instanceof String) {
-                    index = Long.parseLong((String) value);
+                    index = Long.valueOf((String) value);
                 } else if (value instanceof Long) {
                     index = (Long) value;
                 } else {

src/main/java/com/googlecode/hibernate/memcached/MemcachedCacheProvider.java

@@ -166,18 +166,18 @@ protected MemcacheClientFactory getMemcachedClientFactory(Config config) {
                     .getConstructor(PropertiesHelper.class);
         } catch (ClassNotFoundException e) {
             throw new CacheException(
-                    "Unable to find factory class [" + factoryClassName + "]");
+                    "Unable to find factory class [" + factoryClassName + "]", e);
         } catch (NoSuchMethodException e) {
             throw new CacheException(
-                    "Unable to find PropertiesHelper constructor for factory class [" + factoryClassName + "]");
+                    "Unable to find PropertiesHelper constructor for factory class [" + factoryClassName + "]", e);
         }
 
         MemcacheClientFactory clientFactory;
         try {
             clientFactory = (MemcacheClientFactory) constructor.newInstance(config.getPropertiesHelper());
         } catch (Exception e) {
             throw new CacheException(
-                    "Unable to instantiate factory class [" + factoryClassName + "]");
+                    "Unable to instantiate factory class [" + factoryClassName + "]", e);
         }
 
         return clientFactory;

src/main/java/com/googlecode/hibernate/memcached/dangamemcached/DangaMemcacheClientFactory.java

@@ -116,13 +116,13 @@ public ErrorHandler getErrorHandler() {
                     (ErrorHandler) Class.forName(errorHandlerName).newInstance();
         } catch (ClassNotFoundException e) {
             throw new CacheException(
-                    "Unable to find error handler class [" + errorHandlerName + "]");
+                    "Unable to find error handler class [" + errorHandlerName + "]", e);
         } catch (IllegalAccessException e) {
             throw new CacheException(
-                    "Illegally accessed error handler class [" + errorHandlerName + "]");
+                    "Illegally accessed error handler class [" + errorHandlerName + "]", e);
         } catch (InstantiationException e) {
             throw new CacheException(
-                    "Failed to instantiate error handler class [" + errorHandlerName + "]");
+                    "Failed to instantiate error handler class [" + errorHandlerName + "]", e);
         }
 
         return errorHandler;

src/main/java/com/googlecode/hibernate/memcached/utils/StringUtils.java

@@ -72,7 +72,6 @@ private static byte[] digest(String algorithm, String data) {
             throw new RuntimeException(e);
         }
 
-        byte[] bytes = digest.digest(data.getBytes());
-        return bytes;
+        return digest.digest(data.getBytes());
     }
 }