feat(playwright): Remove Cypress auth tests in favor of Playwright auth tests #35938
+187
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the deprecated Cypress authentication tests and makes Playwright
authentication tests required for CI by removing shadow mode.
Changes:
- Remove `continue-on-error: true` from Playwright workflow
- Delete `superset-frontend/cypress-base/cypress/e2e/auth/login.test.ts`
- Playwright auth tests now block CI on failure
The Playwright tests have been running in parallel with Cypress tests
long enough to validate reliability with no false positives/negatives.
Playwright provides full test coverage with enhanced error detection
through Page Object Model pattern and multiple selector strategies.
Both app_root configurations ("" and "/app/prefix") are tested and
validated by the Playwright workflow.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
sadpandajoe
requested review from
betodealmeida,
craig-rueda,
dpgaspar,
eschutho,
geido,
kgabryje,
mistercrunch,
nytai,
rusackas and
villebro
as code owners
Code Review Agent Run #72b6e3Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
github-actions
bot
added
the
github_actions
![korbit-ai[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
This enhances the Playwright workflow to support ongoing test migration: **New Structure:** - `playwright-tests` (required): Runs stable tests, blocks merge on failure - `playwright-tests-experimental` (shadow mode): Runs experimental/ tests with continue-on-error **Changes:** - Split workflow into two jobs for separate status reporting - Updated bashlib.sh to accept TEST_PATH parameter - Created tests/experimental/ directory with migration documentation - Default behavior: run all tests except experimental/ **Migration Path:** New Playwright tests go in experimental/ for validation, then `git mv` to stable when proven. **Branch Protection:** Add `playwright-tests` job to required status checks to enforce. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
sadpandajoe
force-pushed
the
feat-remove-cypress-auth-tests
branch
from
48ef323 to
fd223a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR completes the migration from Cypress to Playwright for authentication tests by:
The Playwright auth tests have been running in parallel with Cypress tests long enough to validate reliability with no false positives or negatives observed. The Playwright implementation provides full test coverage with enhanced error detection through the Page Object Model pattern and multiple selector strategies.
Changes:
Removed deprecated Cypress auth test
superset-frontend/cypress-base/cypress/e2e/auth/login.test.tsSplit Playwright workflow into required and experimental jobs
playwright-tests(required): Runs stable tests, failures block mergeplaywright-tests-experimental(shadow mode): Runs experimental tests withcontinue-on-error: trueCreated directory-based test organization
Migration Path for Future Tests
When migrating tests from Cypress to Playwright:
playwright/tests/experimental/git mvto parent directoryZero workflow maintenance required when adding or promoting tests.
Test Coverage Verified:
""and"/app/prefix"The Playwright workflow tests both app_root configurations and will now be required for merge, ensuring authentication functionality is properly validated in all deployment scenarios.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION