Skip to content

fix(view-in-sqllab): unable to open virtual dataset after discarding chart edits #35931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix(view-in-sqllab): unable to open virtual dataset after discarding chart edits #35931

wants to merge 3 commits into from
+9 −3

Conversation

@EnxDev
Copy link
Contributor

@EnxDev EnxDev commented Oct 31, 2025

SUMMARY

Problem
When modifying a chart and then trying to open the related dataset in SQL Lab without saving, the virtual dataset cannot be opened if you choose to discard the chart edits.

Solution
The navigation hook responsible for handling redirects was only pushing the pathname, causing the component to lose the state (which included the requestedQuery).
The fix ensures that both the pathname and state are preserved when redirecting.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Open chart
  2. Edit chart
  3. click “view in sql lab” from the dataset three dot menu
  4. Warning about losing changes pops up -> click discard
  5. SQL lab opens but the virtual dataset doesn’t load

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API
@EnxDev EnxDev requested a review from geido October 31, 2025 15:34
@dosubot dosubot bot added change:frontend Requires changing the frontend explore Namespace | Anything related to Explore labels Oct 31, 2025
korbit-ai[bot]
korbit-ai bot suggested changes Oct 31, 2025
View reviewed changes
Copy link

@korbit-ai korbit-ai bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Functionality Swapped type annotations for pathname and state parameters ▹ view ✅ Fix detected
Files scanned ​
File Path Reviewed
superset-frontend/src/hooks/useUnsavedChangesPrompt/index.ts ✅
superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx ✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X
bito-code-review[bot]
bito-code-review bot reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@bito-code-review bito-code-review bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Agent Run #29e13f

Actionable Suggestions - 1
  • superset-frontend/src/hooks/useUnsavedChangesPrompt/index.ts - 1
    • Incorrect blockCallback parameter types · Line 77-77
Review Details
  • Files reviewed - 2 · Commit Range: b59ac4d..b59ac4d
    • superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx
    • superset-frontend/src/hooks/useUnsavedChangesPrompt/index.ts
  • Files skipped - 0
  • Tools
    • Eslint (Linter) - ✔︎ Successful
    • Whispers (Secret Scanner) - ✔︎ Successful
    • Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

  • /review - Manually triggers a full AI review.

  • /pause - Pauses automatic reviews on this pull request.

  • /resume - Resumes automatic reviews.

  • /resolve - Marks all Bito-posted review comments as resolved.

  • /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by Bito Logo
@EnxDev EnxDev force-pushed the enxdev/fix/view-in-sql-lab branch from 1a76b75 to 760c1bc Compare October 31, 2025 15:42
@EnxDev EnxDev added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Oct 31, 2025
@github-actions github-actions bot added 🎪 760c1bc 🚦 building Environment 760c1bc status: building 🎪 760c1bc 📅 2025-10-31T16-08 Environment 760c1bc created at 2025-10-31T16-08 🎪 760c1bc ⌛ 48h Environment 760c1bc expires after 48h 🎪 760c1bc 🤡 EnxDev Environment 760c1bc requested by EnxDev and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Oct 31, 2025
@github-actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for 760c1bc
@github-actions github-actions bot added 🎪 760c1bc 🚦 deploying Environment 760c1bc status: deploying 🎪 760c1bc 🚦 running Environment 760c1bc status: running 🎪 🎯 760c1bc Active environment pointer - 760c1bc is receiving traffic 🎪 760c1bc 🌐 44.243.242.40:8080 Environment 760c1bc URL: http://44.243.242.40:8080 (click to visit) and removed 🎪 760c1bc 🚦 building Environment 760c1bc status: building 🎪 760c1bc 🚦 deploying Environment 760c1bc status: deploying 🎪 760c1bc 🚦 running Environment 760c1bc status: running 🎪 🎯 760c1bc Active environment pointer - 760c1bc is receiving traffic labels Oct 31, 2025
@github-actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for 760c1bc

• Environment: http://44.243.242.40:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically
@github-actions github-actions bot added 🎪 48b0bbe 🚦 building Environment 48b0bbe status: building 🎪 48b0bbe 📅 2025-10-31T21-31 Environment 48b0bbe created at 2025-10-31T21-31 labels Oct 31, 2025
@github-actions github-actions bot added 🎪 48b0bbe ⌛ 48h Environment 48b0bbe expires after 48h 🎪 48b0bbe 🤡 EnxDev Environment 48b0bbe requested by EnxDev labels Oct 31, 2025
@github-actions
Copy link
Contributor

🎪 Showtime is building environment on GHA for 48b0bbe
@github-actions github-actions bot added 🎪 48b0bbe 🚦 deploying Environment 48b0bbe status: deploying 🎪 48b0bbe 🚦 running Environment 48b0bbe status: running 🎪 🎯 48b0bbe Active environment pointer - 48b0bbe is receiving traffic 🎪 48b0bbe 🌐 52.37.68.90:8080 Environment 48b0bbe URL: http://52.37.68.90:8080 (click to visit) 🎪 48b0bbe 📅 2025-10-31T21-32 Environment 48b0bbe created at 2025-10-31T21-32 and removed 🎪 48b0bbe 🚦 building Environment 48b0bbe status: building 🎪 48b0bbe 🚦 deploying Environment 48b0bbe status: deploying 🎪 48b0bbe 🚦 running Environment 48b0bbe status: running 🎪 🎯 48b0bbe Active environment pointer - 48b0bbe is receiving traffic 🎪 48b0bbe 📅 2025-10-31T21-31 Environment 48b0bbe created at 2025-10-31T21-31 🎪 760c1bc 📅 2025-10-31T16-08 Environment 760c1bc created at 2025-10-31T16-08 🎪 760c1bc 🌐 44.243.242.40:8080 Environment 760c1bc URL: http://44.243.242.40:8080 (click to visit) 🎪 760c1bc 🤡 EnxDev Environment 760c1bc requested by EnxDev 🎪 760c1bc 🚦 running Environment 760c1bc status: running 🎪 760c1bc ⌛ 48h Environment 760c1bc expires after 48h labels Oct 31, 2025
@github-actions
Copy link
Contributor

🎪 Showtime deployed environment on GHA for 48b0bbe

• Environment: http://52.37.68.90:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

change:frontend Requires changing the frontend explore Namespace | Anything related to Explore size/S 🎪 48b0bbe 🤡 EnxDev Environment 48b0bbe requested by EnxDev 🎪 48b0bbe 🚦 running Environment 48b0bbe status: running 🎪 48b0bbe ⌛ 48h Environment 48b0bbe expires after 48h 🎪 48b0bbe 🌐 52.37.68.90:8080 Environment 48b0bbe URL: http://52.37.68.90:8080 (click to visit) 🎪 48b0bbe 📅 2025-10-31T21-32 Environment 48b0bbe created at 2025-10-31T21-32

1 participant

@EnxDev