Skip to content

[core] Fix data-evolution row count should be more accurate. #6489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[core] Fix data-evolution row count should be more accurate. #6489

wants to merge 5 commits into from

Conversation

@leaves12138
Copy link
Contributor

Purpose

Data evolution table total records in snapshot should be more accurate

Tests

API and Format

Documentation
JingsongLi
JingsongLi reviewed Oct 30, 2025
View reviewed changes
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
deltaRecordCount = nextRowIdStart - firstRowIdStart;
totalRecordCount = nextRowIdStart;
} else {
deltaRecordCount = recordCountAdd(deltaFiles) - recordCountDelete(deltaFiles);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to modify here, we should also modify split row count just like python.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can modify here too, it depends on how it defines
@JingsongLi
Copy link
Contributor

Should we also modify split row count just like python?
@leaves12138
Copy link
Contributor Author

Should we also modify split row count just like python?

Sure~ Fixed as requested~
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@leaves12138 @JingsongLi