[core] collect skipping sets from the left neighbor tag and the neare… #6480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st right neighbor (either the earliest snapshot and right neighbor tag) when tag cleanup
2 tasks
|
Hello, yungkei, thanks for your contribution~ I have a question, you said " if baseManifestList of the nearest right neighbor tag does not exist, the relevant datafiles will be accidentally deleted". I wonder in which case the baseManifestList of the nearest right neighbor tag does not exist? Can you give a more detailed case? Please check . If read failed, the clean will be stopped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] collect skipping sets from the left neighbor tag and the neare…
Purpose
Linked issue: close #6479 [Bug] There are code risks in tag expiration, which can cause data corruption
When a tag expires, the left neighbor tag and the nearest right neighbor tag will be collected in skipping sets to prevent the datafile from being mistakenly deleted. if baseManifestList of the nearest right neighbor tag does not exist, the relevant datafiles will be accidentally deleted. So, I suggest the skipping set can collect both the left neighbor tag and the nearest right neighbor tag, along with the earliest snapshot.