[spark] Refine paimon_sparkx_common dependency #6435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackylee-ch
force-pushed
the
change_paimon_sparkx_common_dependency
branch
2 times, most recently
from
7378dfd to
53bd974
Compare
jackylee-ch
force-pushed
the
change_paimon_sparkx_common_dependency
branch
from
53bd974 to
f418261
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While executing
mvn test -Pspark4 -pl "org.apache.paimon:paimon-spark-4.0_2.13", I encountered a failure in the unit tests becausepaimon-spark3-commonwas being loaded.Further investigation revealed that when running
mvn dependency:tree -pl "org.apache.paimon:paimon-spark-4.0_2.13", I could see thepaimon-spark3-commondependency brought in viapaimon-spark-ut_2.13. The root cause is that the profile defined inpaimon-spark-ut_2.13-1.4.0-SNAPSHOT.jarwas not being propagated, which caused the defaultpaimon-sparkx-commonconfiguration to be applied.This PR resolves the issue by explicitly specifying the profile, ensuring that the profile metadata is passed along, and thus enabling
mvn test -Pspark4 -pl "org.apache.paimon:paimon-spark-4.0_2.13"to run successfully.Tests
GA
API and Format
No.
Documentation
No.