Skip to content

[improvement](BeConfig)Add Be config to control the public or private endpoint #57580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[improvement](BeConfig)Add Be config to control the public or private endpoint #57580

wants to merge 2 commits into from
+9 −3

Conversation

@0AyanamiRei
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

we need to control the public or private endpoint, so add a config in Be:

use_public_endpoint_for_error_log = true : aliyuncs.com
use_public_endpoint_for_error_log = false : -internal.aliyuncs.com

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?
@0AyanamiRei
Copy link
Contributor Author

run buildall
@doris-robot
Copy link

TPC-DS: Total hot run time: 189928 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b965d932c494eb14976b12dd1d3855224bd0f5ad, data reload: false

query1	1040	409	416	409
query2	6568	1690	1738	1690
query3	6745	225	226	225
query4	26070	23530	23050	23050
query5	4821	650	473	473
query6	326	240	240	240
query7	4652	505	299	299
query8	310	283	255	255
query9	8740	2587	2581	2581
query10	539	335	294	294
query11	15315	15401	14953	14953
query12	195	120	112	112
query13	1713	578	458	458
query14	12461	9233	9337	9233
query15	206	193	175	175
query16	7702	672	518	518
query17	1635	786	650	650
query18	2093	494	401	401
query19	235	221	218	218
query20	142	130	130	130
query21	261	135	126	126
query22	4542	4700	4380	4380
query23	34784	33868	34117	33868
query24	8845	2530	2564	2530
query25	660	704	481	481
query26	1550	285	159	159
query27	2742	556	353	353
query28	4572	2259	2249	2249
query29	814	649	504	504
query30	331	239	214	214
query31	912	851	770	770
query32	110	68	69	68
query33	708	391	326	326
query34	830	935	588	588
query35	854	903	803	803
query36	1052	1037	913	913
query37	120	108	87	87
query38	3737	3581	3494	3494
query39	1477	1404	1390	1390
query40	214	123	115	115
query41	61	57	54	54
query42	125	111	109	109
query43	488	504	466	466
query44	1241	754	741	741
query45	181	178	172	172
query46	882	984	654	654
query47	1776	1825	1725	1725
query48	389	440	312	312
query49	777	496	413	413
query50	634	694	403	403
query51	3936	3959	3913	3913
query52	108	108	103	103
query53	236	272	197	197
query54	301	292	276	276
query55	90	86	84	84
query56	341	305	320	305
query57	1169	1207	1131	1131
query58	295	281	274	274
query59	2575	2722	2618	2618
query60	344	356	335	335
query61	154	156	157	156
query62	780	714	666	666
query63	233	198	185	185
query64	4387	1180	859	859
query65	4042	3985	3956	3956
query66	1079	437	343	343
query67	15510	15364	15336	15336
query68	8438	946	613	613
query69	479	313	291	291
query70	1450	1256	1311	1256
query71	505	337	315	315
query72	5881	4911	4838	4838
query73	682	575	367	367
query74	9001	8972	8706	8706
query75	4059	3292	2818	2818
query76	3739	1161	738	738
query77	782	420	313	313
query78	9574	9830	8925	8925
query79	1953	886	638	638
query80	693	577	512	512
query81	505	262	230	230
query82	457	155	132	132
query83	270	256	260	256
query84	258	118	91	91
query85	914	479	435	435
query86	341	325	302	302
query87	3672	3739	3633	3633
query88	3150	2316	2266	2266
query89	385	337	304	304
query90	2014	216	213	213
query91	169	173	137	137
query92	80	67	66	66
query93	1125	986	655	655
query94	702	445	325	325
query95	412	331	321	321
query96	498	590	295	295
query97	2934	2986	2856	2856
query98	238	212	207	207
query99	1650	1435	1306	1306
Total cold run time: 279767 ms
Total hot run time: 189928 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 27.75 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b965d932c494eb14976b12dd1d3855224bd0f5ad, data reload: false

query1	0.05	0.05	0.05
query2	0.09	0.04	0.04
query3	0.25	0.08	0.08
query4	1.60	0.11	0.11
query5	0.28	0.26	0.25
query6	1.18	0.64	0.64
query7	0.02	0.02	0.02
query8	0.06	0.04	0.04
query9	0.60	0.52	0.53
query10	0.59	0.58	0.59
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	1.01	1.00	1.00
query15	0.85	0.83	0.85
query16	0.40	0.42	0.39
query17	1.05	1.07	1.02
query18	0.25	0.20	0.20
query19	1.92	1.79	1.83
query20	0.01	0.02	0.01
query21	15.47	0.17	0.13
query22	5.23	0.07	0.05
query23	15.68	0.27	0.11
query24	2.30	0.54	0.77
query25	0.08	0.07	0.06
query26	0.14	0.13	0.14
query27	0.06	0.06	0.06
query28	4.69	1.13	0.93
query29	12.61	3.96	3.27
query30	0.29	0.14	0.11
query31	2.81	0.61	0.39
query32	3.23	0.56	0.47
query33	3.02	3.09	3.07
query34	15.91	5.22	4.57
query35	4.62	4.62	4.65
query36	0.69	0.51	0.49
query37	0.09	0.07	0.07
query38	0.07	0.04	0.04
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.09	0.03	0.04
query42	0.04	0.03	0.02
query43	0.05	0.03	0.03
Total cold run time: 98.51 s
Total hot run time: 27.75 s
@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.69% (18044/34246)
Line Coverage 37.95% (163833/431746)
Region Coverage 32.28% (124865/386871)
Branch Coverage 33.68% (54611/162133)
@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.40% (24028/33655)
Line Coverage 57.78% (249867/432435)
Region Coverage 52.92% (207677/392425)
Branch Coverage 54.62% (89153/163234)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@0AyanamiRei @hello-stephen @doris-robot