Fix PreCommit Java IO Direct Job

[aIbrahiim]

Fixes: #33793
Successful Run: https://github.com/aIbrahiim/beam/actions/runs/18974662014

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @aIbrahiim, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a failure in the "javaioPreCommit" job by correcting a module dependency path and standardizing Google Cloud dependencies within the "kafka-factories" module. Additionally, it refines the JMS message consumer's timeout handling to improve reliability. These changes collectively aim to enhance the stability of the build process and the robustness of I/O connectors.

Highlights

• PreCommit Job Dependency Fix: The "javaioPreCommit" task in "build.gradle.kts" was updated to correctly reference the "kafka-factories" module, resolving a build dependency issue.
• Standardized Google Cloud Dependencies: The "kafka-factories" module's "build.gradle" now uses the Google Cloud Platform Libraries BOM for managing "google-cloud-secretmanager" dependencies, ensuring consistent versioning.
• JMS Message Consumer Timeout Logic: The "JmsIO" message consumer logic was adjusted to always call "consumer.receive()" with a positive timeout, specifically "1L" when "receiveTimeoutMillis" is "0L", to prevent potential issues with "receiveNoWait()".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @m-trieu for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[damccorm]

R: @fozzie15 @johnjcasey

It looks like #36099 broke Precommits, please take a look

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

[damccorm]

Could you explain why we need this change? It seems like we are no longer respecting the set receive timeout

[Abacn]

Yeah let's revert JmsIO change. This is a long standing flaky test likely due to test infra (in-memory jms server)

[aIbrahiim]

The change was made to address a NullPointerException in JmsIOTest.testCheckpointMarkSafety. When receiveTimeoutMillis was 0, it used consumer.receiveNoWait(), which can return null immediately if no message is available. In the test environment with in memory jms server this led to a race where the test proxy wrapper returned null, causing that NullPointerExption

The fix replaced receiveNoWait() with receive(1L) when the timeout was 0, ensuring a minimal wait that could allow the message to arrive.
However, as @Abacn noted this masks a test infrastructure issue so I will revert it

[Abacn]

we need to add sdks/java/extensions/kafka-factories to the trigger path of https://github.com/apache/beam/blob/master/.github/workflows/beam_PreCommit_Java_IOs_Direct.yml that's why this wasn't captured

[aIbrahiim]

Added