Only log Kafka commit failures every 10m and if failing for > 10m.

[tomstepp]

Only log Kafka commit failures every 10m and if failing for > 10m.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @tomstepp, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses potential log spam by implementing a rate-limiting strategy for Kafka commit failure warnings. Instead of logging every transient commit failure, the system will now only log warnings when failures are sustained over a period of time and haven't been recently reported, leading to cleaner and more actionable logs.

Highlights

• Rate-limiting Kafka commit failure logs: Introduced a mechanism to prevent excessive logging of Kafka commit failures. Warnings will now only be logged if failures have been occurring for more than 10 minutes since the last successful commit, and if a warning hasn't been logged in the last 10 minutes.
• New constants and state variables: Added MIN_COMMIT_FAIL_LOG_INTERVAL (10 minutes) and instance variables lastSuccessfulCommitTime and lastCommitErrorLogTime to KafkaUnboundedReader to manage the new logging logic.
• Conditional logging in commitCheckpointMark: The commitCheckpointMark method now checks the elapsed time since the last successful commit and the last error log before emitting a warning for a commit failure, ensuring warnings are less frequent and more indicative of persistent issues.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Assigning reviewers:

R: @ahmedabu98 for label java.
R: @fozzie15 for label kafka.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[tomstepp]

R: @scwhittle

[github-actions]

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers