-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Adds fields to ProcessBundleRequest #36683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Adds fields to ProcessBundleRequest #36683
Conversation
Summary of ChangesHello @wolfchris-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request extends the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
…ted proto classes (apache#36680) * Fix test expectations which appear to fail with differences in proto generation * fix spotless
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #36683 +/- ##
============================================
- Coverage 40.21% 40.21% -0.01%
Complexity 3394 3394
============================================
Files 1222 1221 -1
Lines 186913 186909 -4
Branches 3545 3545
============================================
- Hits 75174 75172 -2
+ Misses 108367 108365 -2
Partials 3372 3372
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
…pache#36681) * Free disk space for snapshot job * Move to correct requirements file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM according to what's been discussed. Final chance to bikeshed on field names if anyone is so inclined.
Update Beam version for republish released docker containers workflow
* draft * Simplify * Add xlang test markers. * Fix tests. * lints * Remove extractor_fn args. * Linter. --------- Co-authored-by: Claude <cvandermerwe@google.com>
) * Add comments about holding refreshCond lock when accessing processing time queue. * Acquire lock before add pending. Unexport ProcessTimeNow in em. * Remove unnecessary lock aquiring in startTriggeredBundle. * Update the test to skip after apache#36655
…or fetching/writing state.
…or fetching/writing state.
… fn-api-state-batch-overrides
|
R: @kennknowles please take a look when you get a chance! |
|
There's a lot in this PR that does not appear to be intended. Perhaps you could rebase against the master branch and force push to your branch, so that it would show only the relevant commit(s) |
Adds fields to ProcessBundleRequest. These fields will be used to disable SDK fetching and writing state.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.