-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Remove Python 3.9 support from Apache Beam #36665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jrmccluskey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on removing Python 3.9 support from Apache Beam and transitioning the project to Python 3.10. This involves updating various configuration files, test suites, and infrastructure components to ensure compatibility and maintainability with the new Python version. The changes aim to streamline the project's focus on actively supported Python versions. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| 'Intended Audience :: End Users/Desktop', | ||
| 'License :: OSI Approved :: Apache Software License', | ||
| 'Operating System :: POSIX :: Linux', | ||
| 'Programming Language :: Python :: 3.9', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While reviewing sdks/python/setup.py, I noticed two areas that might be relevant to our Python version update:
- The
python_requires = '>=3.9'setting - A dependency with a Python version constraint:
psycopg2-binary>=2.8.5,<2.9.10; python_version <= "3.9"
If we proceed with dropping Python 3.9 support, these would likely need updates:
python_requireswould change to'>=3.10'- The
psycopg2-binarypy package constraint may need adjustment forpython_version >= "3.10"
Not sure though if updating this would require other ripple effect changes specifically for corresponding py packages upper/lower bound(s) for major/minor versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm actively working on this PR and will be cleaning up other language references as I fix breakages in workflows that migrate to 3.10 (most notably our linting setup needs a full overhaul.)
I will likely take the version constraints out specifically in a follow-up that also deletes Docker container and tox definitions
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Removes support for Python 3.9 (reached EOL in October 2025) and migrates relevant workflows to Python 3.10. As part of this migration, isort and pylint were updated to versions that support Python 3.10. This led to formatting changes impacting multiple files. As a benefit, the configuration for isort now largely exists within a configuration file rather than within run_pylint.sh; this allows developers to use isort locally to fix their files before running the lint precommit.
Workflow Runs on branch:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.