Skip to content

Commit 836ac95

Browse files
move logging from controller to servies layer | enable debug level
1 parent c761f79 commit 836ac95

File tree

4 files changed

+61
-61
lines changed

4 files changed

+61
-61
lines changed

‎src/main/java/org/moren/spring/controller/NoteController.java

Lines changed: 7 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,6 @@
44

55
import org.moren.spring.domain.Note;
66
import org.moren.spring.service.NoteService;
7-
import org.slf4j.Logger;
8-
import org.slf4j.LoggerFactory;
97
import org.springframework.beans.factory.annotation.Autowired;
108
import org.springframework.stereotype.Controller;
119
import org.springframework.ui.Model;
@@ -16,14 +14,15 @@
1614
@RequestMapping("/notes")
1715
public class NoteController {
1816

19-
private Logger log = LoggerFactory.getLogger(NoteController.class);
20-
21-
@Autowired
2217
private NoteService noteService;
2318

19+
@Autowired
20+
public void setNoteService(NoteService noteService) {
21+
this.noteService = noteService;
22+
}
23+
2424
@GetMapping
2525
public String Getnotes(@RequestParam(defaultValue = "") String search, Model model) {
26-
2726
model.addAttribute("note", new Note());
2827

2928
if (search.equals("")) {
@@ -43,40 +42,27 @@ public String getCreateNote(Model model) {
4342

4443
@PostMapping("create")
4544
public String createNote(@ModelAttribute @Valid Note note, BindingResult result, Model model) {
46-
4745
if(result.hasErrors()) {
48-
log.warn("Can't save, note has white space or null {}", note);
4946
return "create";
5047
}
51-
48+
5249
noteService.save(note);
53-
log.info("Save {}", note);
54-
5550
return "redirect:/";
5651
}
5752

5853
@PostMapping("delete")
5954
public String deleteNote(Integer id) {
60-
61-
log.info("Delete {}", noteService.getById(id));
62-
6355
noteService.delete(id);
64-
6556
return "redirect:/notes";
6657
}
6758

6859
@PostMapping("edit")
6960
public String editNote(@ModelAttribute @Valid Note note, BindingResult result) {
70-
7161
if(result.hasErrors()) {
72-
log.warn("Can't update, note has white space or null {}", note);
7362
return "redirect:/";
7463
}
75-
76-
log.info("Update {} to {}", noteService.getById(note.getId()), note);
77-
78-
noteService.update(note);
7964

65+
noteService.update(note);
8066
return "redirect:/";
8167
}
8268

‎src/main/java/org/moren/spring/controller/NoteRestController.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,14 @@
1111
@RestController
1212
@RequestMapping("/api")
1313
public class NoteRestController {
14-
15-
@Autowired
14+
1615
private NoteService NoteService;
1716

17+
@Autowired
18+
public void setNoteService(org.moren.spring.service.NoteService noteService) {
19+
NoteService = noteService;
20+
}
21+
1822
@GetMapping("/all")
1923
public List<Note> api() {
2024
return NoteService.getAll();

‎src/main/java/org/moren/spring/service/imp/NoteServiceImpl.java

Lines changed: 47 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -6,48 +6,58 @@
66
import org.moren.spring.domain.Note;
77
import org.moren.spring.repository.NoteRepository;
88
import org.moren.spring.service.NoteService;
9+
import org.slf4j.Logger;
10+
import org.slf4j.LoggerFactory;
911
import org.springframework.beans.factory.annotation.Autowired;
1012
import org.springframework.stereotype.Service;
1113

1214
@Service
1315
public class NoteServiceImpl implements NoteService {
1416

15-
@Autowired
16-
private NoteRepository noteRepository;
17-
18-
@Override
19-
public void save(Note note) {
20-
noteRepository.save(note);
21-
}
22-
23-
@Override
24-
public void update(Note note) {
25-
noteRepository.save(note);
26-
}
27-
28-
@Override
29-
public void delete(Integer id) {
30-
noteRepository.deleteById(id);
31-
}
32-
33-
@Override
34-
public List<Note> getAll() {
35-
return noteRepository.findByOrderByIdDesc();
36-
}
37-
38-
@Override
39-
public List<Note> getByTitle(String title) {
40-
return noteRepository.findByTitleContainingIgnoreCase(title);
41-
}
42-
43-
@Override
44-
public List<Note> getByDescription(String description) {
45-
return noteRepository.findByDescriptionContainingIgnoreCase(description);
46-
}
47-
48-
@Override
49-
public Optional<Note> getById(Integer id) {
50-
return noteRepository.findById(id);
51-
}
17+
private final Logger log = LoggerFactory.getLogger(this.getClass());
18+
private NoteRepository noteRepository;
19+
20+
@Autowired
21+
public void setNoteRepository(NoteRepository noteRepository) {
22+
this.noteRepository = noteRepository;
23+
}
24+
25+
@Override
26+
public void save(Note note) {
27+
noteRepository.save(note);
28+
log.debug("Save {}", note);
29+
}
30+
31+
@Override
32+
public void update(Note note) {
33+
noteRepository.save(note);
34+
log.debug("Update {}", note);
35+
}
36+
37+
@Override
38+
public void delete(Integer id) {
39+
log.debug("Delete {}", noteRepository.findById(id).get());
40+
noteRepository.deleteById(id);
41+
}
42+
43+
@Override
44+
public List<Note> getAll() {
45+
return noteRepository.findByOrderByIdDesc();
46+
}
47+
48+
@Override
49+
public List<Note> getByTitle(String title) {
50+
return noteRepository.findByTitleContainingIgnoreCase(title);
51+
}
52+
53+
@Override
54+
public List<Note> getByDescription(String description) {
55+
return noteRepository.findByDescriptionContainingIgnoreCase(description);
56+
}
57+
58+
@Override
59+
public Optional<Note> getById(Integer id) {
60+
return noteRepository.findById(id);
61+
}
5262

5363
}

‎src/main/resources/application.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,4 @@ spring.jpa.open-in-view=false
1111
server.port=${PORT:8080}
1212

1313
# log
14-
logging.level.com.moren=info
14+
logging.level.org.moren.spring=debug

0 commit comments

Comments
 (0)
close