Destination Snowflake: break down ensureSchemaMatches

[edgao]

What

branched from #69090

How

There are a few major hacks here:

• getColumnsFromStream actually parses out the "NOT NULL", because SnowflakeColumnUtils.columnsAndTypes returns strings like NUMBER(38,0) NOT NULL. Probably would be nicer to have columnsAndTypes return the new ColumnType struct directly, instead of destination-snowflake's bespoke ColumnAndType - but that would be a lot of code churn right now
• I deleted the isPrimaryKey field from ColumnDefinition, b/c it wasn't actually used anywhere. But now ColumnDefinition is identical to ColumnAndType (which, again, we probably should delete entirely)...
• SqlGenerator.alterTable manually filters out nullable -> non-nullable changes, b/c destination-snowflake actually tries to respect field nullability, but this alteration feels likely to cause problems. I could be convinced to just do the blind alter though.

TODO unit tests are probably completely broken

Can this PR be safely reverted and rolled back?

• YES 💚
• NO ❌

[github-actions]

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

• Breaking Changes Guide - Breaking changes, migration guides, and upgrade deadlines
• Developing Connectors Locally
• Managing Connector Secrets
• On-Demand Live Tests
• On-Demand Regression Tests
• #connector-ci-issues
• #connector-publish-updates
• #connector-build-statuses

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

• /format-fix - Fixes most formatting issues.
• /bump-version - Bumps connector versions.
  • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
  • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
• /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
• /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
• JVM connectors:
  • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
    Example: /update-connector-cdk-version connector=destination-bigquery
  • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
• Python connectors:
  • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
  • /poe source example lock - Alias for /poe connector source-example lock.
  • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
  • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

[github-actions]

destination-snowflake Connector Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 28cf33f.

♻️ This comment has been updated with latest results.

[github-actions]

Note

Detected that there are differences in the Gradle dependencies.

• https://github.com/airbytehq/airbyte/runs/54235321824