Skip to content

Conversation

@edgao
Copy link
Contributor

@edgao edgao commented Oct 31, 2025

What

Branched from #69090

How

Notable behavior changes:

  • Instead of recomputing the table name (nameGenerator.getTableName(stream.mappedDescriptor)), we just use the tableName provided in the method signature
  • When computing the expected schema, instead of recomputing the column name (fieldName.toClickHouseCompatibleName()), we take the column name from the ColumnNameMapping

TODO unit tests are probably completely broken

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌
@github-actions
Copy link
Contributor

👋 Greetings, Airbyte Team Member!

Here are some helpful tips and reminders for your convenience.

Helpful Resources

PR Slash Commands

Airbyte Maintainers (that's you!) can execute the following slash commands on your PR:

  • /format-fix - Fixes most formatting issues.
  • /bump-version - Bumps connector versions.
    • You can specify a custom changelog by passing changelog. Example: /bump-version changelog="My cool update"
    • Leaving the changelog arg blank will auto-populate the changelog from the PR title.
  • /run-cat-tests - Runs legacy CAT tests (Connector Acceptance Tests)
  • /build-connector-images - Builds and publishes a pre-release docker image for the modified connector(s).
  • JVM connectors:
    • /update-connector-cdk-version connector=<CONNECTOR_NAME> - Updates the specified connector to the latest CDK version.
      Example: /update-connector-cdk-version connector=destination-bigquery
    • /bump-bulk-cdk-version type=patch changelog='foo' - Bump the Bulk CDK's version. type can be major/minor/patch.
  • Python connectors:
    • /poe connector source-example lock - Run the Poe lock task on the source-example connector, committing the results back to the branch.
    • /poe source example lock - Alias for /poe connector source-example lock.
    • /poe source example use-cdk-branch my/branch - Pin the source-example CDK reference to the branch name specified.
    • /poe source example use-cdk-latest - Update the source-example CDK dependency to the latest available version.

📝 Edit this welcome message.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

destination-clickhouse Connector Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 2a60df1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Note

Detected that there are differences in the Gradle dependencies.

@edgao edgao force-pushed the edgao/schema_evolution_test/cdk branch from 745f4ca to 8e02044 Compare October 31, 2025 23:46
@edgao edgao force-pushed the edgao/schema_evolution_test/clickhouse branch from cb81e0b to 2a60df1 Compare October 31, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment