Set this.oldData before calling update to enable recursive setAttribute within the updat method

Author: dmarcos

src/core/component.js

@@ -266,11 +266,11 @@ Component.prototype = {
       // We pass empty object to multiple property schemas and single property schemas that parse to objects like position, rotation, scale
       // undefined is passed to the rest of types.
       oldData = (!isSinglePropSchema || typeof parseProperty(undefined, this.schema) === 'object') ? {} : undefined;
+      // Store current data as previous data for future updates.
+      this.oldData = extendProperties({}, this.data, isSinglePropSchema);
       this.update(oldData);
       // Play the component if the entity is playing.
       if (el.isPlaying) { this.play(); }
-      // Store current data as previous data for future updates.
-      this.oldData = extendProperties({}, this.data, isSinglePropSchema);
       el.emit('componentinitialized', {
         id: this.id,
         name: this.name,

tests/core/component.test.js

@@ -674,6 +674,26 @@ suite('Component', function () {
       assert.deepEqual(updateStub.getCalls()[1].args[0], {x: 1, y: 1, z: 1});
       assert.deepEqual(el.components.dummy.data, {x: 2, y: 2, z: 2});
     });
+
+    test('oldData and data is properly passed on recursive calls to setAttribute', function () {
+      var el = this.el;
+      registerComponent('dummy', {
+        schema: {
+          color: {default: 'red'},
+          size: {default: 0}
+        },
+        update: function (oldData) {
+          if (this.data.color === 'red') {
+            this.el.setAttribute('dummy', 'color', 'blue');
+          }
+          if (oldData.color === 'red') {
+            this.el.setAttribute('dummy', 'color', 'green');
+          }
+        }
+      });
+      el.setAttribute('dummy', 'color: red');
+      assert.equal(el.getAttribute('dummy').color, 'green');
+    });
   });
 
   suite('flushToDOM', function () {