Fix outdated comments still mentioning WebVR (#5694)

Author: vincentfretin

src/core/scene/a-scene.js

@@ -245,7 +245,7 @@ export class AScene extends AEntity {
   }
 
   /**
-   * Call `requestPresent` if WebVR or WebVR polyfill.
+   * Call `requestSession` if WebXR is supported.
    * Call `requestFullscreen` on desktop.
    * Handle events, states, fullscreen styles.
    *
@@ -325,10 +325,7 @@ export class AScene extends AEntity {
       }
       self.addFullScreenStyles();
 
-      // On mobile, the polyfill handles fullscreen.
-      // TODO: 07/16 Chromium builds break when `requestFullscreen`ing on a canvas
-      // that we are also `requestPresent`ing. Until then, don't fullscreen if headset
-      // connected.
+      // Call `requestFullscreen` on desktop
       if (!self.isMobile && !self.checkHeadsetConnected()) {
         requestFullscreen(self.canvas);
       }
@@ -339,7 +336,7 @@ export class AScene extends AEntity {
   }
 
   /**
-   * Call `exitPresent` if WebVR / WebXR or WebVR polyfill.
+   * Call `xrSession.end` if WebXR.
    * Handle events, states, fullscreen styles.
    *
    * @returns {Promise}
@@ -351,7 +348,7 @@ export class AScene extends AEntity {
     // Don't exit VR if not in VR.
     if (!this.is('vr-mode') && !this.is('ar-mode')) { return Promise.resolve('Not in immersive mode.'); }
 
-    // Handle exiting VR if not yet already and in a headset or polyfill.
+    // Handle exiting VR if not yet already and in a headset or mobile.
     if (this.checkHeadsetConnected() || this.isMobile) {
       vrManager.enabled = false;
       if (this.hasWebXR) {
@@ -469,10 +466,10 @@ export class AScene extends AEntity {
     isVRPresenting = this.renderer.xr.enabled && isPresenting;
 
     // Do not update renderer, if a camera or a canvas have not been injected.
-    // In VR mode, three handles canvas resize based on the dimensions returned by
-    // the getEyeParameters function of the WebVR API. These dimensions are independent of
+    // In VR mode, three handles canvas resize based on the dimensions of the created
+    // XRWebGLLayer or XRProjectionLayer. These dimensions are independent of
     // the window size, therefore should not be overwritten with the window's width and
-    // height, // except when in fullscreen mode.
+    // height, except when in fullscreen mode.
     if (!camera || !canvas || (this.is('vr-mode') && (this.isMobile || isVRPresenting))) {
       return;
     }
@@ -835,7 +832,7 @@ function getCanvasSize (canvasEl, embedded, maxSize, isVR) {
 
 /**
  * Return the canvas size. Will be the window size unless that size is greater than the
- * maximum size (1920x1920 by default).  The constrained size will be returned in that case,
+ * maximum size (no maximum by default). The constrained size will be returned in that case,
  * maintaining aspect ratio
  *
  * @param {object} maxSize - Max size parameters (width and height).

src/utils/device.js

@@ -6,7 +6,6 @@ var supportsARSession = false;
 
 export var isWebXRAvailable = navigator.xr !== undefined;
 
-// Support both WebVR and WebXR APIs.
 if (isWebXRAvailable) {
   var updateEnterInterfaces = function () {
     var sceneEl = document.querySelector('a-scene');

tests/core/scene/a-scene.test.js

@@ -117,7 +117,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('calls requestPresent if headset connected', function (done) {
+    test('calls requestSession if headset connected', function (done) {
       var sceneEl = this.el;
       this.sinon.stub(sceneEl, 'checkHeadsetConnected').returns(true);
       window.hasNativeWebVRImplementation = false;
@@ -127,7 +127,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('calls requestPresent on mobile', function (done) {
+    test('calls requestSession on mobile', function (done) {
       var sceneEl = this.el;
       sceneEl.isMobile = true;
       sceneEl.enterVR().then(function () {
@@ -136,7 +136,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('does not call requestPresent if flat desktop', function (done) {
+    test('does not call requestSession if flat desktop', function (done) {
       var sceneEl = this.el;
       this.sinon.stub(sceneEl, 'checkHeadsetConnected').returns(false);
       this.sinon.stub(sceneEl.canvas, 'requestFullscreen');
@@ -238,7 +238,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('calls exitPresent if headset connected', function (done) {
+    test('calls xrSession.end if headset connected', function (done) {
       var sceneEl = this.el;
       this.sinon.stub(sceneEl, 'checkHeadsetConnected').returns(true);
       sceneEl.xrSession = {
@@ -251,7 +251,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('calls exitPresent on mobile', function (done) {
+    test('calls xrSession.end on mobile', function (done) {
       this.sinon.stub(screen.orientation, 'lock');
       var sceneEl = this.el;
       sceneEl.isMobile = true;
@@ -265,7 +265,7 @@ suite('a-scene (without renderer) - WebXR', function () {
       });
     });
 
-    test('does not call exitPresent on desktop without a headset', function (done) {
+    test('does not call xrSession.end on desktop without a headset', function (done) {
       var sceneEl = this.el;
       sceneEl.renderer.xr.enabled = true;
       sceneEl.isMobile = false;