Theme: Optimize color generating algorithm #72883
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jarda Snajdr <664258+jsnajdr@users.noreply.github.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
[Type] Performance
aduth
commented
Oct 31, 2025
| // Disable reason: ESLint resolver can't handle `exports`. Import resolver | ||
| // checking is redundant in TypeScript files. | ||
| // eslint-disable-next-line import/no-unresolved | ||
| } from 'colorjs.io/fn'; |
There was a problem hiding this comment.
I'm going to open a separate pull request to disable this rule altogether for TypeScript files. We don't need it.
See: https://typescript-eslint.io/troubleshooting/typed-linting/performance/#eslint-plugin-import
There was a problem hiding this comment.
I'm going to open a separate pull request to disable this rule altogether for TypeScript files. We don't need it.
See: https://typescript-eslint.io/troubleshooting/typed-linting/performance/#eslint-plugin-import
Pull request opened at #72884
|
Size Change: -7.09 kB (-0.3%) Total Size: 2.37 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates theme color generation algorithm to be more efficient:
Why?
Ensure that ThemeProvider can generate colors without excessive runtime performance cost, since it's expected that this would be rendered at or close to the application root element.
Testing Instructions
Validate no regressions in behavior of behavior of theme provider:
npm run storybook:startVerify that building theme package succeeds and produces no local changes:
npm run --workspace @wordpress/theme buildgit status