Notes: Hide pinned sidebar when there are no notes #72872
+34
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Feature] Notes
|
Size Change: +2 B (0%) Total Size: 2.38 MB
ℹ️ View Unchanged
|
|
@Mamaduka - this empty pinned sidebar state will never show after this change: gutenberg/packages/editor/src/components/collab-sidebar/comments.js Lines 310 to 326 in b41c908 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The test failures seem to be coming from focus loss, eg here is the first one: gutenberg/test/e2e/specs/editor/various/block-comments.spec.js Lines 69 to 70 in b41c908 When testing manually, after submitting the new note, I briefly see the note disappear, then reappear and regain focus. That seems off, ideally the new note form would transform into the new thread without that refresh. Are we already working on that? in any case, introducing a brief delay before the focus check might fix this? Screencast - everything but selecting "... Add note" is done with the keyboard: Screen.Recording.2025-11-01.at.11.56.16.AM.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #72750.
🚧 Work in progress, some e2e tests are failing due to logic change 🚧
Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast