parsing/tokenizer: partial revert of 5141f7c6 (#735)#745
Merged
LarsAsplund merged 1 commit intoVUnit:masterfrom Sep 24, 2021
Merged
parsing/tokenizer: partial revert of 5141f7c6 (#735)#745LarsAsplund merged 1 commit intoVUnit:masterfrom
LarsAsplund merged 1 commit intoVUnit:masterfrom
Conversation
umarcor
force-pushed
the
fix-tokenizer
branch
from
e00ec8c to
60462cc
Compare
Collaborator
|
Or maybe I just messed up :-) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #735.
As discussed in #735, this improves performance significantly.
The previous change was done because of some linter issue. However, this PR seems not to trigger any new warning. Therefore the original issue might have been a temporary rule in the linter.