Editor: getCurrentUserAsAuthor

Author: Zane

src/Controller/Editor/ArticleEditBaseController.php

@@ -6,6 +6,7 @@
 use App\Service\Cms\ArticleEditor;
 use App\Service\Factory;
 use App\Service\FrontendHelper;
+use App\Service\User;
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
@@ -15,6 +16,7 @@
 
 abstract class ArticleEditBaseController extends BaseController
 {
+    protected User $currentUserAsAuthor;
 
     public function __construct(
         protected Factory $factory,
@@ -31,9 +33,8 @@ protected function loadArticleEditor(int $articleId) : ArticleEditor
     {
         $this->ajaxOnly();
 
-        if( empty($this->getUser()) ) {
-            throw $this->createAccessDeniedException('Non sei loggato!');
-        }
+        // login check
+        $this->getCurrentUserAsAuthor();
 
         $this->articleEditor->load($articleId);
 
@@ -45,6 +46,29 @@ protected function loadArticleEditor(int $articleId) : ArticleEditor
     }
 
 
+    protected function getCurrentUserAsAuthor() : User
+    {
+        /**
+         * $currentUser is unknown to Doctrine: if we try to set it as Author directly:
+         *
+         * A new entity was found through the relationship 'App\Entity\Cms\ArticleAuthor#user' that was not configured
+         *   to cascade persist operations for entity: App\Entity\PhpBB\User@--
+         */
+
+        if( !empty($this->currentUserAsAuthor) ) {
+            return $this->currentUserAsAuthor;
+        }
+
+        $currentUserId = $this->getUser()?->getId();
+
+        if( empty($currentUserId) ) {
+            throw $this->createAccessDeniedException('Non sei loggato!');
+        }
+
+        return $this->factory->createUser()->load($currentUserId);
+    }
+
+
     protected function jsonOKResponse(string $okMessage) : JsonResponse
     {
         return $this->json([

src/Controller/Editor/ArticleNewController.php

@@ -68,14 +68,7 @@ public function new() : Response
     #[Route('/scrivi/salva',  name: 'app_article_new_submit', methods: ['POST'])]
     public function submit() : Response
     {
-        $currentUser = $this->factory->getCurrentUser();
-
-        if( empty($currentUser) ) {
-
-            throw $this->createAccessDeniedException(
-                'Non sei loggato! Solo gli utenti registrati possono creare nuovi articoli.'
-            );
-        }
+        $currentUserAsAuthor = $this->getCurrentUserAsAuthor();
 
         $this->validateCsrfToken();
 
@@ -96,17 +89,10 @@ public function submit() : Response
 
         $newArticleFormat = $this->request->get(static::FORMAT_FIELD_NAME);
 
-        /*
-         * $currentUser is unknown to Doctrine: if we try to set it as Author directly:
-         * A new entity was found through the relationship 'App\Entity\Cms\ArticleAuthor#user' that was not configured to cascade persist operations for entity: App\Entity\PhpBB\User@--
-         */
-        $currentUserId = $currentUser->getId();
-        $author = $this->factory->createUser()->load($currentUserId);
-
         $this->articleEditor
             ->setFormat($newArticleFormat)
-            ->addAuthor($author)
-            ->autotag($author)
+            ->addAuthor($currentUserAsAuthor)
+            ->autotag($currentUserAsAuthor)
             ->save();
 
         return $this->redirect( $this->articleEditor->getUrl() );