refactor set article authors via setAuthors

Article editor: images gallery

Author: Zane

src/Controller/Editor/ArticleEditAuthors.php

@@ -58,9 +58,18 @@ public function setAuthors(int $articleId) : JsonResponse|Response
     {
         try {
 
+            $currentUserAsAuthor = $this->getCurrentUserAsAuthor();
+
+            $this->loadArticleEditor($articleId);
+
             $arrAuthorIds = $this->request->get('authors') ?? [];
-            $this->loadArticleEditor($articleId)->setAuthorsFromIds($arrAuthorIds);
+
+            $authors = $this->factory->createUserCollection()->load($arrAuthorIds);
+
+            $this->articleEditor->setAuthors($authors, $currentUserAsAuthor);
+
             $this->factory->getEntityManager()->flush();
+
             return $this->jsonOKResponse("Autori salvati");
 
         } catch(Exception|Error $ex) { return $this->textErrorResponse($ex); }

src/Controller/Editor/ArticleEditTags.php

@@ -67,6 +67,7 @@ public function setTags(int $articleId) : JsonResponse|Response
             $this->articleEditor->setTags($tags, $currentUserAsAuthor);
 
             $this->factory->getEntityManager()->flush();
+
             return $this->jsonOKResponse("Tag salvati");
 
         } catch(Exception|Error $ex) { return $this->textErrorResponse($ex); }

src/Entity/Cms/Article.php

@@ -97,16 +97,23 @@ public function getAuthors() : Collection { return $this->authors; }
 
     public function addAuthor(ArticleAuthor $author) : static
     {
+        $ranking = 0;
         $currentItems = $this->getAuthors();
         foreach($currentItems as $item) {
 
             if( $item->getUser()->getId() == $author->getUser()->getId() ) {
                 return $this;
             }
+
+            $itemRanking    = $item->getRanking();
+            $ranking        = $itemRanking > $ranking ? $itemRanking : $ranking;
         }
 
+        $author
+            ->setArticle($this)
+            ->setRanking(++$ranking);
+
         $this->authors->add($author);
-        $author->setArticle($this);
 
         return $this;
     }

src/Service/Cms/ArticleEditor.php

@@ -116,70 +116,36 @@ public function addAuthor(User $author) : static
     }
 
 
-    public function setAuthorsFromIds(array $arrAuthorIds) : static
+    public function setAuthors(iterable $newAuthors, User $author) : static
     {
-        if( empty($arrAuthorIds) ) {
-            throw new ArticleUpdateException('L\'articolo deve avere almeno 1 autore');
-        }
-
-        $arrAuthorIds = array_unique($arrAuthorIds);
+        // invalidate the cached author list
+        $this->arrAuthors = null;
 
-        $collNewAuthors = $this->factory->createUserCollection()->load($arrAuthorIds);
-
-        if( $collNewAuthors->count() < 1 ) {
-            throw new ArticleUpdateException('L\'articolo deve avere almeno 1 autore');
+        $oldAuthorJunctions = $this->entity->getAuthors()->getValues();
+        foreach($oldAuthorJunctions as $junction) {
+            $this->entity->removeAuthor($junction);
         }
 
-        // rebuild the cached author list
-        $this->arrAuthors = [];
-
-        $entityManager = $this->factory->getEntityManager();
-
-        // these would be junctions (array-of-ArticleAuthor)
-        $currentAuthors = $this->entity->getAuthors();
-
-        // remove current authors who are no longer
-        foreach($currentAuthors as $junction) {
-
-            $authorId   = $junction->getUser()->getId();
-            $newAuthor  = $collNewAuthors->get($authorId);
+        $oldAuthorJunctionByAuthorId = [];
+        foreach($oldAuthorJunctions as $junction) {
 
-            if( empty($newAuthor) ) {
-                $entityManager->remove($junction);
-            }
+            $authorId = $junction->getUser()->getId();
+            $oldAuthorJunctionByAuthorId[$authorId] = $junction;
         }
 
-        // add new users
-        $i=1;
-        foreach($collNewAuthors as $author) {
+        foreach($newAuthors as $user) {
 
-            $existingJunction = null;
-            foreach($currentAuthors as $junction) {
+            $userId = $user->getId();
+            $existingAuthorJunction = $oldAuthorJunctionByAuthorId[$userId] ?? null;
 
-                if( $author->getId() == $junction->getUser()->getId() ) {
+            if( empty($existingAuthorJunction) ) {
 
-                    $existingJunction = $junction;
-                    break;
-                }
-            }
+                $this->addAuthor($user);
 
-            if( empty($existingJunction) ) {
+            } else {
 
-                $existingJunction =
-                    (new ArticleAuthor())
-                        ->setArticle($this->entity)
-                        ->setUser( $author->getEntity() );
+                $this->entity->addAuthor($existingAuthorJunction);
             }
-
-            $existingJunction->setRanking($i);
-            $entityManager->persist($existingJunction);
-
-            $i++;
-
-            // rebuild the cached author list so that $article->getAuthors() works without a reload
-            $userEntity                     = $author->getEntity();
-            $authorId                       = $userEntity->getId();
-            $this->arrAuthors[$authorId]    = $this->factory->createUser($userEntity);
         }
 
         return $this;