Skip to content

Conversation

@Ludy87
Copy link
Collaborator

@Ludy87 Ludy87 commented Oct 31, 2025

Description of Changes

This pull request makes minor improvements to the German localization and translation management. The changes primarily update UI strings for clarity and consistency and adjust the translation ignore list.

Localization improvements:

  • Updated urgent update notification and related UI strings in messages_de_DE.properties for better clarity and consistency.
  • Improved analytics labels and translated "Scarf Pixel" to "Schal-Pixel" in messages_de_DE.properties.

Translation management:

  • Removed scannerEffect.quality.medium from the translation ignore list in ignore_translation.toml.

Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.
Copilot AI review requested due to automatic review settings October 31, 2025 17:42
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines ignoring generated files. label Oct 31, 2025
@stirlingbot
Copy link
Contributor

stirlingbot bot commented Oct 31, 2025

🚀 Translation Verification Summary

🔄 Reference Branch: main-branch-messages_en_GB.properties

📃 File Check: messages_de_DE.properties

  1. Test Status:Passed
  2. Test Status:Passed
  3. Test Status:Passed

✅ Overall Check Status: Success

Thanks @Ludy87 for your help in keeping the translations up to date.

@stirlingbot stirlingbot bot added Documentation Improvements or additions to documentation enhancement New feature or request Translation labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves German translations for the Stirling PDF application by completing an incomplete translation string and enabling translation for a previously ignored key.

  • Removed scannerEffect.quality.medium from the translation ignore list
  • Fixed incomplete urgent update notification text in German
  • Updated analytics labels to use German translations

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
scripts/ignore_translation.toml Removed scannerEffect.quality.medium from ignore list to enable proper translation
app/core/src/main/resources/messages_de_DE.properties Fixed incomplete urgent update text and updated analytics cookie labels with German translations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Ludy87 Ludy87 enabled auto-merge (squash) October 31, 2025 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation enhancement New feature or request size:XS This PR changes 0-9 lines ignoring generated files. Translation

1 participant