Redesign tsconfig.json files #4781
Open
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrunton96
requested review from
ConnorYoh,
EthanHealy01,
Frooodle and
reecebrowne
as code owners
dosubot
bot
added
the
size:S
jbrunton96
force-pushed
the
V2-tsconfig
branch
from
d6f0a34 to
f1f8c52
Compare
|
🚀 Auto-deploying V2 version for PR #4781... This is an automated deployment triggered by V2/version2 keywords in the PR title or V2/React keywords in the branch name. |
✅ Frontend License Check PassedAll frontend licenses have been validated and no compatibility warnings were detected. The frontend license report has been updated successfully. |
reecebrowne
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Changes where the various
tsconfig.jsonfiles for proprietary/core live and names themtsconfig.json. This improves developer experience inside VSCode because in VSCode you can't specify whichtsconfigfile to use, it just picks the one in the folder based on name - but it can have multiple loaded for different folders. So, with this change, opening files in thecorefolder will have VSCode analyse them with thecore/tsconfig.jsonfile, and files inproprietarywill be analysed withproprietary/tsconfig.json. This isn't particularly important in current V2 (you'll basically not notice it) but will make a difference in the Desktop version in #3854 when there's a third folder.