Skip to content

Conversation

@reecebrowne
Copy link
Contributor

Description of Changes


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.
commit f1901a2
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 27 18:23:27 2025 +0000

    revert lint

commit 09b0fbe
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 27 15:47:38 2025 +0000

    Hide file names in posthog

commit 3497ccd
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 27 12:45:31 2025 +0000

    remove page break settings modal

commit 5e27dc8
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 27 12:37:00 2025 +0000

    retain interleaving

commit b276eb5
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 27 11:32:31 2025 +0000

    Lint

commit aec1f97
Author: Reece <reece@stirlingpdf.com>
Date:   Sat Oct 25 14:19:32 2025 +0100

    -

commit fbe2dc2
Author: Reece <reece@stirlingpdf.com>
Date:   Sat Oct 25 13:06:10 2025 +0100

    Fixed file reordering placeholder

commit aaae81c
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:57:30 2025 +0100

    -

commit 3aa7781
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:54:30 2025 +0100

    -

commit 28dab07
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:51:37 2025 +0100

    -

commit ed6199d
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:51:29 2025 +0100

    lint and revert onboarding

commit 4d59ebf
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:27:44 2025 +0100

    fixed drag and drop when some files aren't selected in context

commit ea4f37c
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 15:06:21 2025 +0100

    Merge history change

commit c25131a
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 14:48:14 2025 +0100

     lint

commit 25df941
Merge: 494f924 848ff96
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 14:33:27 2025 +0100

    Merge branch 'V2' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/selected-pageeditor

commit 494f924
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 13:28:50 2025 +0100

    Enhance drag-and-drop functionality with new drop hint resolution and target index calculation; refactor file color mapping in PageEditor and implement dropdown state management for improved file handling.

commit eef5dce
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 24 11:33:31 2025 +0100

    Drag and drop improvements basic box select

commit ddefe81
Author: Reece <reece@stirlingpdf.com>
Date:   Thu Oct 23 20:46:58 2025 +0100

    Enhance DragDropGrid and PageEditor with improved undo manager functionality and scroll handling during drag operations

commit be037b7
Author: Reece <reece@stirlingpdf.com>
Date:   Thu Oct 23 18:15:37 2025 +0100

    File reorder logic

commit 7a56f05
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 21 17:35:55 2025 +0100

    Refactor file handling to support StirlingFileStubs and improve drag-and-drop functionality

commit f7c9855
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 21:45:00 2025 +0100

    glow scaling

commit 36a358f
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 21:25:44 2025 +0100

    Visual tweaks

commit 0bcb181
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 21:08:18 2025 +0100

    tweak

commit aee5352
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 20:55:45 2025 +0100

    Pretty lights

commit 6d3154a
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 20:44:48 2025 +0100

    Update top bar controls visually

commit 658ce2d
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 18:45:14 2025 +0100

    add file

commit 15df5cf
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 18:05:55 2025 +0100

    -

commit 23d7f38
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 17:24:16 2025 +0100

    lint

commit 472fc29
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 15:56:54 2025 +0100

    lint 2

commit a21047e
Merge: 8ee03fa 3e23dc5
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Mon Oct 20 15:52:23 2025 +0100

    Merge branch 'V2' into feature/v2/selected-pageeditor

commit 8ee03fa
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 15:50:14 2025 +0100

    Lint

commit a22913e
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 14:16:41 2025 +0100

    page editor fixes post merge

commit b3c0c69
Merge: 2289080 3e6236d
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 20 13:42:08 2025 +0100

    Merge branch 'V2' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/selected-pageeditor

commit 2289080
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 17 16:55:29 2025 +0100

    remove buttons

commit a5ec62f
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 17 15:24:05 2025 +0100

    Performance improvements

commit e7f7b7e
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 17 14:15:21 2025 +0100

    improved

commit 74e8388
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 15 21:33:54 2025 +0100

    Working mostly

commit e7c6db0
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 15 16:31:30 2025 +0100

    Rejig arrays

commit 05a7161
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 15 00:01:30 2025 +0100

    Structural tweaks

commit 39267e7
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 14 12:41:50 2025 +0100

    Reworked page editor - dirty commit

commit 6acce96
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 19:32:41 2025 +0100

    fix 2

commit 0722ecc
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 19:27:15 2025 +0100

    fix

commit 3597a8b
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 19:16:04 2025 +0100

    Initial set up

commit c260394
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 17:15:07 2025 +0100

    Cleanup

commit 93fcfb2
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 17:09:36 2025 +0100

    Remove logs tweak visuals, use fit text component

commit 69cb8e7
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 16:54:05 2025 +0100

    Fix signwith tab based system

commit 8e8e066
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 15:57:41 2025 +0100

    Nav based file select

commit 5d37102
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 13:37:52 2025 +0100

    Lint

commit ad8789d
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 13:35:18 2025 +0100

    remove file that came from nowhere

commit 749966a
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 13:30:15 2025 +0100

    Remove mantine theme

commit d9e429a
Merge: ad0b6cf b695e39
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 13:00:56 2025 +0100

    Merge branch 'V2' of https://github.com/Stirling-Tools/Stirling-PDF into feature/V2/ViewerTabs

commit ad0b6cf
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Oct 10 12:55:03 2025 +0100

    Viewer tabs, embed update and layout fixes

commit b63f2c1
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 15:12:39 2025 +0100

    Remove unused legacy text signing Linting errors

commit edcc788
Merge: 5b47ab5 fdba336
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 15:02:39 2025 +0100

    Merge branch 'feature/v2/improve-sign' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/improve-sign

commit 5b47ab5
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 15:02:33 2025 +0100

    Remove debug logs

commit fdba336
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Wed Oct 8 14:57:29 2025 +0100

    Update frontend/src/components/annotation/shared/DrawingCanvas.tsx

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit 5db6b85
Merge: 70d941a 13e8894
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 14:56:10 2025 +0100

    Merge branch 'feature/v2/improve-sign' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/improve-sign

commit 70d941a
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 14:55:43 2025 +0100

    translations

commit 13e8894
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Wed Oct 8 14:55:04 2025 +0100

    Update frontend/src/components/tools/sign/SignSettings.tsx

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit 339e5cf
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Wed Oct 8 14:54:31 2025 +0100

    Update frontend/src/contexts/ViewerContext.tsx

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit 10944d9
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 14:45:39 2025 +0100

    Remove debug logging

commit 0c9f460
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 14:02:43 2025 +0100

    Remove arbitrary timers

commit fa6e01b
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Oct 8 12:26:34 2025 +0100

    Clean up

commit 23f85d7
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 22:40:58 2025 +0100

    tweaks

commit f6290c0
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 21:52:40 2025 +0100

    - Refactored signature saving process

commit 991be9f
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 21:38:07 2025 +0100

    Add text color and font size options to signature settings and API

commit 07bf79f
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 14:54:14 2025 +0100

    Improved canvas mode with signaturepad.js

commit 3a0acd0
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 12:56:12 2025 +0100

    Single canvas

commit fff6372
Author: Reece <reece@stirlingpdf.com>
Date:   Tue Oct 7 12:08:32 2025 +0100

    Clean up annotation layer and signature API

    - Remove duplicate imports in LocalEmbedPDF
    - Remove duplicate setAnnotations state declaration
    - Rename enableSignature prop to enableAnnotations for consistency
    - Remove debug console.log statements from SignatureAPIBridge
    - Remove async image preloading wrapper (was debugging code)
    - Clean up formatting

    🤖 Generated with [Claude Code](https://claude.com/claude-code)

    Co-Authored-By: Claude <noreply@anthropic.com>

commit 8f94c8f
Merge: 708a296 2a29bda
Author: Reece <reece@stirlingpdf.com>
Date:   Mon Oct 6 22:25:30 2025 +0100

    Merge branch 'V2' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/improve-sign

commit 708a296
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 19:14:40 2025 +0100

    Auto update canvas signature

commit b486d12
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 19:03:24 2025 +0100

    Fix flicker on apply

commit 80faf0b
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 18:55:09 2025 +0100

    -

commit 6555a95
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 18:53:16 2025 +0100

    Fix even more linting errors (Thanks James)

commit fdee719
Merge: 1be48c2 fd9fb9b
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 18:14:42 2025 +0100

    Merge branch 'feature/v2/sign' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/sign

commit 1be48c2
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 18:12:13 2025 +0100

    fix text infinite loop

commit 2b6b7a8
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 18:04:01 2025 +0100

    better error handling and killing logs

commit fd9fb9b
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Fri Sep 26 17:58:52 2025 +0100

    Update frontend/src/hooks/tools/sign/useSignParameters.ts

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit d8d6197
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:48:41 2025 +0100

    fix page count issue

commit 1edd133
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:31:44 2025 +0100

    license checker use commonJS

commit 8685bf2
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:26:19 2025 +0100

    gap

commit 3647506
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:23:16 2025 +0100

    lint fix

commit 3aa8572
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:16:17 2025 +0100

    Fix suggestions

commit 2e2d847
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 17:01:06 2025 +0100

    Clean up

commit 90880ed
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Fri Sep 26 16:51:19 2025 +0100

    Update docker/frontend/nginx.conf

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit 31fd688
Merge: 3fdbf42 abc0988
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Fri Sep 26 16:40:34 2025 +0100

    Merge branch 'V2' into feature/v2/sign

commit 3fdbf42
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 16:39:38 2025 +0100

    Fix lintineg errors

commit 50e60d4
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 16:27:52 2025 +0100

    Simple export block

commit a22330e
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 16:09:20 2025 +0100

    Only flatten current annotations

commit 172f622
Merge: cfd00b2 d82b958
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 15:10:54 2025 +0100

    Merge branch 'feature/v2/sign' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/sign

commit cfd00b2
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 15:10:47 2025 +0100

    Render signature to pdf

commit d82b958
Merge: c94ee38 0bdc646
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Fri Sep 26 12:53:54 2025 +0100

    Merge branch 'V2' into feature/v2/sign

commit c94ee38
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 12:47:32 2025 +0100

    Restructure and bug fix

commit aa5333d
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 03:23:59 2025 +0100

    Change to button based placement to avoid performance issue on canvas

commit a8265ef
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 03:19:05 2025 +0100

    Improved performance

commit b9b425a
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 02:18:47 2025 +0100

    Fix undo/redo

commit 51caad6
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 01:51:17 2025 +0100

    Reduce logs

commit 023fd43
Author: Reece <reece@stirlingpdf.com>
Date:   Fri Sep 26 01:49:33 2025 +0100

    Save file

commit a8a0808
Author: Reece <reece@stirlingpdf.com>
Date:   Thu Sep 25 09:46:20 2025 +0100

    history tweaks

commit 3d2607f
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Sep 24 19:01:36 2025 +0100

    fixes

commit f9542a9
Merge: a12e457 9637873
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Sep 24 18:35:16 2025 +0100

    Merge branch 'feature/v2/exportpdf' into feature/v2/sign

commit 9637873
Author: Reece <reece@stirlingpdf.com>
Date:   Wed Sep 24 17:42:58 2025 +0100

    Export with embedpdf

commit a12e457
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Wed Sep 24 14:58:10 2025 +0100

    Add undo/redo functionality and refactor signature settings UI

    - Introduced HistoryAPIBridge for managing undo/redo actions.
    - Updated SignSettings component to include undo/redo buttons.
    - Refactored signature type selection to use Tabs for better UI.
    - Enhanced SignatureAPIBridge to store image data for annotations.
    - Integrated history management into SignatureContext for state handling.

commit bac61c7
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 23 18:16:21 2025 +0100

    Delete signature

commit fc2f34e
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 23 17:18:39 2025 +0100

    fix add image

commit d9798ba
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 23 14:06:41 2025 +0100

    Fix sidebar refresh. Updated UI

commit efc0c1a
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 23 12:24:58 2025 +0100

    text and improved drawing

commit 1067240
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 22 14:14:35 2025 +0100

    Colours on document draw + translations

commit 32fed96
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 22 14:03:49 2025 +0100

    Canvas and dosument draw split, drawing improvements

commit a70472b
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Sat Sep 20 01:59:04 2025 +0100

    Initial set up

commit 3b87ca0
Merge: 0e1da98 6172351
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 19 11:38:58 2025 +0100

    Merge branch 'feature/v2/embed-pdf' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/embed-pdf

commit 0e1da98
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 19 11:38:53 2025 +0100

    Fix vite

commit 6172351
Merge: 1174b6a ae7be50
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Fri Sep 19 11:23:28 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit 1174b6a
Merge: a970c44 21a2433
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 19 11:16:22 2025 +0100

    Merge branch 'feature/v2/embed-pdf' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/embed-pdf

commit a970c44
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 19 11:14:58 2025 +0100

    improvements

commit b574cef
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 19 10:48:29 2025 +0100

    improvements

commit 21a2433
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Thu Sep 18 13:14:44 2025 +0100

    Remove marginTop style from Workbench component

commit 07cc250
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Thu Sep 18 13:12:58 2025 +0100

    Remove comment regarding EmbedPDF import

    Removed comment about dynamic import of EmbedPDF.

commit dc71b30
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 18 12:32:42 2025 +0100

    clean up

commit 1598057
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 18 08:44:57 2025 +0100

    Tweaks

commit 312fc2d
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 18 02:14:31 2025 +0100

    Clean up

commit 72375d8
Merge: a990ecc 7ff1c66
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Thu Sep 18 01:53:59 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit a990ecc
Merge: da6ecc6 b51c2e4
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Thu Sep 18 01:53:47 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit da6ecc6
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Wed Sep 17 14:35:44 2025 +0100

    Fix scroll page identification

commit dac176f
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Wed Sep 17 12:07:44 2025 +0100

    Fix colours

commit 41e5a7f
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Wed Sep 17 12:00:20 2025 +0100

    Restructure to avoid global variables
    fix zoom

commit b81ed9e
Merge: 9b5c50d 81c5d8f
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 16 19:37:50 2025 +0100

    Merge branch 'feature/v2/embed-pdf' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/embed-pdf

commit 9b5c50d
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Tue Sep 16 19:36:36 2025 +0100

    Improved Structure with context at root

commit 81c5d8f
Author: James Brunton <james@stirlingpdf.com>
Date:   Tue Sep 16 16:06:40 2025 +0100

    Potential fix for mime type issues

commit a67f519
Author: James Brunton <james@stirlingpdf.com>
Date:   Tue Sep 16 16:06:27 2025 +0100

    Improvements for scroll gestures

commit 3755bfd
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 18:20:11 2025 +0100

    Set zoom to 140%

commit 2834eec
Merge: 19d7111 d89e1b5
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 17:31:06 2025 +0100

    Merge branch 'feature/v2/embed-pdf' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/embed-pdf

commit d89e1b5
Merge: 5d7fb63 a57373b
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Mon Sep 15 17:27:51 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit 19d7111
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 17:27:22 2025 +0100

    Remove unused code

commit ca9d7ef
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 17:03:52 2025 +0100

    Remove unused code

commit fad4f84
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 16:53:41 2025 +0100

    translations

commit 35863ac
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 16:53:32 2025 +0100

    remove select mode

commit c17dd25
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 16:05:19 2025 +0100

    Rotate

commit 5d7fb63
Merge: 2fb4710 7dad484
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Mon Sep 15 15:31:45 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit 2fb4710
Merge: 85a74c1 cfdb6ea
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Mon Sep 15 13:34:00 2025 +0100

    Merge branch 'V2' into feature/v2/embed-pdf

commit 85a74c1
Merge: 21a93d6 9599bca
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 13:33:45 2025 +0100

    Merge branch 'feature/v2/embed-pdf' of https://github.com/Stirling-Tools/Stirling-PDF into feature/v2/embed-pdf

commit 21a93d6
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Mon Sep 15 13:33:39 2025 +0100

    Context based right rail controls for viewer

commit 9599bca
Author: Reece Browne <74901996+reecebrowne@users.noreply.github.com>
Date:   Mon Sep 15 12:37:07 2025 +0100

    Update frontend/src/components/viewer/ThumbnailSidebar.tsx

    Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

commit 1709ca9
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 16:38:29 2025 +0100

    Rems

commit 18e4e03
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 16:26:05 2025 +0100

    rename APIBridge

commit 9901771
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 16:19:07 2025 +0100

    improve search

commit 5149565
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 15:06:06 2025 +0100

    pan state improvements

commit 423617d
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 14:21:31 2025 +0100

    thumbnail sidebar

commit 143f0c5
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 01:56:51 2025 +0100

    search pdf

commit 368e980
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Fri Sep 12 00:35:27 2025 +0100

    Zoom with wheel and +/-

commit afc9ca5
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 23:52:38 2025 +0100

    spread/multipage

commit 8815575
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 22:51:10 2025 +0100

    pan

commit fb9b01f
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 20:07:43 2025 +0100

    improved scaling and fix grey void

commit 9360793
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 19:38:04 2025 +0100

    selection also

commit 687ab39
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 19:36:44 2025 +0100

    Text selection

commit 83a3222
Author: Reece Browne <reecebrowne1995@gmail.com>
Date:   Thu Sep 11 19:08:44 2025 +0100

    Set up
@stirlingbot stirlingbot bot added v2 Issues or pull requests related to the v2 branch Java Pull requests that update Java code Back End Issues related to back-end development Docker Pull requests that update Docker code Security Security-related issues or pull requests API API-related issues or pull requests Test Testing-related issues or pull requests Gradle Pull requests that update Gradle code labels Oct 28, 2025
@reecebrowne reecebrowne force-pushed the feature/v2/selected-pageeditor-rework branch from 5dea4d0 to 3bd1c9f Compare October 28, 2025 16:10
@stirlingbot stirlingbot bot removed Java Pull requests that update Java code Back End Issues related to back-end development Docker Pull requests that update Docker code Security Security-related issues or pull requests API API-related issues or pull requests Test Testing-related issues or pull requests Gradle Pull requests that update Gradle code labels Oct 28, 2025
@stirlingbot stirlingbot bot added Java Pull requests that update Java code Back End Issues related to back-end development Docker Pull requests that update Docker code Security Security-related issues or pull requests API API-related issues or pull requests Test Testing-related issues or pull requests Gradle Pull requests that update Gradle code labels Oct 28, 2025
@reecebrowne reecebrowne force-pushed the feature/v2/selected-pageeditor-rework branch from 11c7335 to c6c986a Compare October 28, 2025 18:35
@stirlingbot stirlingbot bot removed Java Pull requests that update Java code Back End Issues related to back-end development Docker Pull requests that update Docker code labels Oct 28, 2025
@reecebrowne reecebrowne marked this pull request as ready for review October 29, 2025 09:42
Copilot AI review requested due to automatic review settings October 29, 2025 09:42
@reecebrowne reecebrowne requested a review from Frooodle as a code owner October 29, 2025 09:42
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines ignoring generated files. enhancement New feature or request labels Oct 29, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a comprehensive page editor enhancement with file-level organization, improved drag-and-drop functionality, and visual feedback systems. The key changes include:

  • Migration from Atlaskit pragmatic-drag-and-drop to dnd-kit for improved drag-and-drop UX
  • Introduction of PageEditorContext for coordinating file and page reordering
  • File color coding system (20 distinct colors) for visual organization
  • Box selection for batch page operations
  • Zoom controls with wheel/keyboard support
  • File dropdown with reorderable file list in top controls

Reviewed Changes

Copilot reviewed 29 out of 31 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
frontend/package.json Added @dnd-kit/core dependency for drag-and-drop functionality
frontend/src/core/contexts/PageEditorContext.tsx New context managing page editor state, file ordering, and file selection
frontend/src/core/hooks/useWheelZoom.ts New shared hook for wheel-based zoom with accumulator pattern
frontend/src/core/components/pageEditor/hooks/usePageDocument.ts Enhanced to support placeholders for deselected files and insertion positioning
frontend/src/core/components/pageEditor/PageEditor.tsx Major refactor with zoom support, file color coding, and improved state management
frontend/src/core/components/pageEditor/DragDropGrid.tsx Complete rewrite using dnd-kit with box selection and improved drop indicators
frontend/src/core/components/shared/TopControls.tsx Added PageEditorFileDropdown for file management in toolbar
frontend/src/core/components/shared/PageEditorFileDropdown.tsx New dropdown component for file selection and reordering
frontend/src/core/types/pageEditor.ts Added isPlaceholder flag for deselected file placeholders
frontend/src/core/styles/zIndex.ts Added z-index constants for page editor UI layers
frontend/src/core/components/pageEditor/commands/pageCommands.ts Added PageBreakSettings interface and onReorderComplete callback
Files not reviewed (1)
  • frontend/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)

frontend/src/core/components/pageEditor/PageEditor.tsx:1

  • Using React.useRef and React.useEffect instead of the imported hooks. For consistency with the rest of the file where these hooks are imported and used directly, use useRef and useEffect here.
import { useState, useCallback, useRef, useEffect, useMemo } from "react";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

selected: boolean;
splitAfter?: boolean;
isBlankPage?: boolean;
isPlaceholder?: boolean;
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The isPlaceholder field is added to the PDFPage interface but pageBreakSettings is also referenced in pageCommands.ts line 475 yet is not defined in this interface. Consider adding pageBreakSettings?: PageBreakSettings; to the PDFPage interface for type consistency.

Copilot uses AI. Check for mistakes.
@@ -1,4 +1,4 @@
/**
/**
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A UTF-8 BOM (Byte Order Mark) character is present at the start of the file. This is generally unnecessary for UTF-8 files and can cause issues with some tools. Remove the BOM character.

Suggested change
/**
/**
Copilot uses AI. Check for mistakes.
});

// Notify parent when hover state changes
React.useEffect(() => {
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using React.useEffect instead of the imported useEffect. For consistency with the rest of the file where useEffect is imported and used directly, use useEffect here.

Suggested change
React.useEffect(() => {
useEffect(() => {
Copilot uses AI. Check for mistakes.
});

// Notify parent when hover state changes
React.useEffect(() => {
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using React.useEffect instead of the imported useEffect. For consistency with the rest of the file where useEffect is imported and used directly, use useEffect here.

Suggested change
React.useEffect(() => {
useEffect(() => {
Copilot uses AI. Check for mistakes.
Comment on lines +158 to +161
const prevFileContextIdsRef = React.useRef<FileId[]>([]);

// Initialize fileOrder from FileContext when files change (add/remove only)
React.useEffect(() => {
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using React.useRef and React.useEffect instead of importing them from 'react'. For consistency with line 1 where useRef and useEffect are not explicitly imported (only useState, useCallback, useMemo are), consider importing and using these hooks directly.

Copilot uses AI. Check for mistakes.

// Moving into the tooltip → keep open
if (related && tooltipRef.current && tooltipRef.current.contains(related)) {
if (related && related instanceof Node && tooltipRef.current && tooltipRef.current.contains(related)) {
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check related instanceof Node is redundant since related is already typed as Node | null and the preceding related && check ensures it's truthy. The instanceof Node check can be removed for cleaner code.

Suggested change
if (related && related instanceof Node && tooltipRef.current && tooltipRef.current.contains(related)) {
if (related && tooltipRef.current && tooltipRef.current.contains(related)) {
Copilot uses AI. Check for mistakes.

const currentRect = currentEl.getBoundingClientRect();
const nextPage = displayedPages[position + 1];
let lineLeft = currentRect.right;
Copy link

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The initial value of lineLeft is unused, since it is always overwritten.

Suggested change
let lineLeft = currentRect.right;
let lineLeft;
Copilot uses AI. Check for mistakes.
Copy link

@jbrunton96 jbrunton96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a quick scan over to find import issues, not a proper review

Co-authored-by: James Brunton <jbrunton96@gmail.com>
@stirlingbot stirlingbot bot removed the enhancement New feature or request label Oct 29, 2025
reecebrowne and others added 2 commits October 29, 2025 11:13
Co-authored-by: James Brunton <jbrunton96@gmail.com>
Co-authored-by: James Brunton <jbrunton96@gmail.com>
@stirlingbot
Copy link
Contributor

stirlingbot bot commented Oct 29, 2025

✅ Frontend License Check Passed

All frontend licenses have been validated and no compatibility warnings were detected.

The frontend license report has been updated successfully.

@stirlingbot
Copy link
Contributor

stirlingbot bot commented Oct 29, 2025

🚀 V2 Auto-Deployment Complete!

Your V2 PR with the new frontend/backend split architecture has been deployed!

🔗 Direct Test URL (non-SSL) http://185.252.234.121:4756

🔐 Secure HTTPS URL: https://4756.ssl.stirlingpdf.cloud

This deployment will be automatically cleaned up when the PR is closed.

🔄 Auto-deployed because PR title or branch name contains V2/version2/React keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines ignoring generated files. v2 Issues or pull requests related to the v2 branch

3 participants