Skip to content

Conversation

@EthanHealy01
Copy link
Contributor

Description of Changes

  • Addition of the compare tool

Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.
@stirlingbot stirlingbot bot added the v2 Issues or pull requests related to the v2 branch label Oct 27, 2025
@stirlingbot
Copy link
Contributor

stirlingbot bot commented Oct 28, 2025

✅ Frontend License Check Passed

All frontend licenses have been validated and no compatibility warnings were detected.

The frontend license report has been updated successfully.

@EthanHealy01 EthanHealy01 marked this pull request as ready for review October 29, 2025 02:01
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines ignoring generated files. enhancement New feature or request labels Oct 29, 2025
@reecebrowne
Copy link
Contributor

Once you hit compare need to block selection or open the new view with loading as you can break it by deselecting a file

@reecebrowne
Copy link
Contributor

reecebrowne commented Oct 29, 2025

Hit compare then swap pdf, the compare is rerunning but I am sat in file editor wondering what I am supposed to do. That swap PDF button is confusing when first uploading files, isn't really needed until we load in and probably should be within the view or the right rail rather than the toolstep
image

@reecebrowne
Copy link
Contributor

Virtualised scroll is too aggressive, needs an overscan buffer so we aren't loading only when in view

@reecebrowne
Copy link
Contributor

Loading bar stuck

image
@reecebrowne
Copy link
Contributor

reecebrowne commented Oct 29, 2025

Zoom needs to be tied to scroll bar, need to fix scaling one or both of theviews break most of the time when I zom in and out (master zoom)
image

@reecebrowne
Copy link
Contributor

image Would be nice on ultrawide/more zoomed out views to make use of the space when we are zooming
@stirlingbot stirlingbot bot removed the enhancement New feature or request label Oct 29, 2025
@stirlingbot
Copy link
Contributor

stirlingbot bot commented Oct 30, 2025

🚀 V2 Auto-Deployment Complete!

Your V2 PR with the new frontend/backend split architecture has been deployed!

🔗 Direct Test URL (non-SSL) http://185.252.234.121:4751

🔐 Secure HTTPS URL: https://4751.ssl.stirlingpdf.cloud

This deployment will be automatically cleaned up when the PR is closed.

🔄 Auto-deployed because PR title or branch name contains V2/version2/React keywords.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL This PR changes 1000+ lines ignoring generated files. v2 Issues or pull requests related to the v2 branch

4 participants