Repository navigation
fix: Andres comments - #9
Merged
Merged
Conversation
added 2 commits
February 26, 2025 18:54
adefreitas
approved these changes
Feb 27, 2025
adefreitas
left a comment
adefreitas
left a comment
There was a problem hiding this comment.
My python knowledge is limited but looks good to me!
willleeney
added a commit
that referenced
this pull request
Oct 28, 2026
…ts matching PR (#389) Both SDKs' conformance runs grade the pair together, and the new contract needs both on it. The Node pin moves to its merge commit once #389 lands.
willleeney
added a commit
that referenced
this pull request
Oct 29, 2026
…e (ENG-3175) (#231) * refactor!: one search_execute listing spanning every account, served as the trio search() and execute() call stackone_search_actions / stackone_execute_action once, replacing the per-account meta-tool fan-out, connector parsing, re-ranking and the failed-account retry in execute(). Hits carry available_accounts, not account_id. WIP: shared vectors not yet re-vendored; README/MIGRATION/examples and the Pydantic AI test still to do. * test(ENG-3175): run Pydantic AI agents over the trio; vendor the new vectors; document hits' available_accounts Vendors sdk-conformance@65e1286's vectors, which drop the per-connector messages and add trio-tool-not-served. A FunctionModel-driven Agent now runs a tool end to end against the mock MCP server in individual and search_execute modes. README, MIGRATION and the examples show search hits naming available_accounts rather than account_id, and the Pydantic AI example runs a search_execute agent too. * feat!: span search/execute with one comma-separated scope; present a one-account pair as the trio's names (ENG-3175) * ci(ENG-3175): pin sdk-conformance at #9's merge and the Node SDK at its matching PR (#389) Both SDKs' conformance runs grade the pair together, and the new contract needs both on it. The Node pin moves to its merge commit once #389 lands. * ci(ENG-3175): take the conformance job's pnpm from sdk-conformance's packageManager sdk-conformance moved to pnpm 11.17.0 (#12), and pnpm/action-setup refuses a version key that disagrees with package_json_file. Each SDK checkout still runs its own pnpm 10.26.0: pnpm switches to a project's packageManager version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.