Skip to content

Conversation

@ritoban23
Copy link

📄 Summary

This PR fixes a janky user experience on the Sign In screen where, after submitting credentials, the login screen briefly flashes again before redirecting to the dashboard. The change ensures a smooth transition from loading to dashboard after successful authentication.


✅ Changes

  • Bug fix: Prevents login screen from flashing after successful sign-in by showing a loading spinner when the user is already authenticated.
  • UI: Improves login flow for a seamless user experience.

🏷️ Required: Add Relevant Labels

⚠️ Manually add appropriate labels in the PR sidebar
Please select one or more labels (as applicable):

  • frontend
  • bug
  • ui
  • enhancement

👥 Reviewers

Tag the relevant teams for review:

  • frontend

🧪 How to Test

  1. Start the frontend dev server.
  2. Go to the login screen and sign in with valid credentials.
  3. Observe the flow: after clicking "Sign In," you should see a loading spinner and then be redirected directly to the dashboard, without the login screen flashing again.
  4. Try reloading /login while already authenticated; you should see a spinner and be redirected to the dashboard.

🔍 Related Issues

Closes #9417


📸 Screenshots / Screen Recording (if applicable / mandatory for UI related changes)


📋 Checklist

  • Dev Review
  • Test cases added (Unit/ Integration / E2E)
  • Manually tested the changes

👀 Notes for Reviewers

  • The fix is minimal and only affects the login flow.
  • No breaking changes to other authentication or routing logic.
@ritoban23 ritoban23 requested review from a team and YounixM as code owners October 27, 2025 20:02
@welcome
Copy link

welcome bot commented Oct 27, 2025

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2025

CLA assistant check
All committers have signed the CLA.

@ritoban23 ritoban23 force-pushed the fix/login-screen-flash branch from 4ebd5d2 to f57d1ca Compare October 27, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants