Cherry pick PR826 from Ladybird #26349
Open
+167
−150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6be559f6394b210ddd3db48fb158d7410adbd2a1)
Manual cherry-pick of e8b7c88 (without Skia and with DisplayListPlayer{CPU,GPU} support).
This change is a preparation for the upcoming changes where display list will be nested and the same display could be owned by multiple display list items. (cherry picked from commit 50ab564)
Before this change, "background-clip: text" was implemented by saving a Vector<Gfx::Path> of all glyphs needed to paint a mask for the background. The issue with this approach was that once glyphs were extracted into vector paths, the glyph rasterization cache could no longer be utilized. With this change, all text required for mask painting is saved in a nested display list and rasterized as a regular text. (cherry picked from commit 67d68ea; amended for DisplayListPlayerCPU compatibility)
github-actions
bot
added
the
👀 pr-needs-review
|
(6be559f6 is the first commit of LadybirdBrowser/ladybird#5390) |
nico
approved these changes
Nov 2, 2025
| } | ||
|
|
||
| auto& command = m_commands[next_command_index++].command; | ||
| auto& command = commands[next_command_index++].command; |
There was a problem hiding this comment.
The original PR also touches what's line 149 in this file. Do we not need that? Are we missing an earlier cherry-pick?
There was a problem hiding this comment.
So the executor stack mechanism was removed upstream in 0b48c1e (while we still need it). Thus the original commit doesn't have to deal with any nested players, so it can just call would_be_fully_clipped_by_painter and executor_method via this (whereas we need to go through current_executor, so those lines incidentally stay the same).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(and also 6be559f6, because the second commit in this PR needs that).
This was fairly non-trivial (since
DisplayListPlayerCPU.{cpp,h}don't exist upstream), and is almost an NFC, but this should hopefully unblock some other commits should we choose to cherry-pick those.The visual differences in
css-background-clip-text.pnglook similar to the ones upstream in LadybirdBrowser/ladybird#826, so that seems more-or-less fine I guess.