fix: trigger recalculation when snapshots change

[pauldambra]

this was very 🤯 for me

we had aggressively cached the snapshot data because the processing is so heavy on the browser

it would only be recreated when we polled the full listing snapshots after we'd loaded all data

this was fine when we weren't playing until we had loaded all the data

but, the better i made progressive loading, the less often we polled full data, and the longer the gap between loading some data and it being available to the player

to keep the processing cheap we keep the count of successful API calls on the cached object and recreate the object instance when that changes so that downstream selectors recalculate

(in theory that's not necessary, but in practice it was firing more and the browser was thrashing unnecessarily)

[uploading 2025-11-01 20.07.40.gif...]

[pauldambra]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix: trigger recalculation when snapshots change #40772 👈 (View in Graphite)
• fix: safer progressive loading #40768
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Size Change: 0 B

Total Size: 3.34 MB

ℹ️ View Unchanged

Filename	Size
frontend/dist/toolbar.js	3.34 MB

_{compressed-size-action}

[greptile-apps]

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

[posthog-bot]

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

• chromium: 0 added, 2 modified, 0 deleted (diff for shard 14)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[github-actions]

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

• playwright/__snapshots__/pageview-trends-insight.png

What this means:

• These screenshots are changing on each test run (timing issues, rendering differences, etc.)
• This prevents reliable verification and blocks auto-merge
• Human intervention is required

How to fix:

1. Investigate flakiness: Check test timing, wait for elements, stabilize animations
2. Fix the underlying issue: Don't just update snapshots repeatedly
3. Verify locally: Run tests multiple times to ensure stability
4. Push your fix: This will reset the flap counter

If you need to proceed anyway:

• Fix the test flakiness first (recommended)
• Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

[posthog-bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

• chromium: 0 added, 3 modified, 0 deleted (diff for shard 14, diff for shard 15)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[github-actions]

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

• playwright/__snapshots__/pageview-trends-insight.png

What this means:

• These screenshots are changing on each test run (timing issues, rendering differences, etc.)
• This prevents reliable verification and blocks auto-merge
• Human intervention is required

How to fix:

1. Investigate flakiness: Check test timing, wait for elements, stabilize animations
2. Fix the underlying issue: Don't just update snapshots repeatedly
3. Verify locally: Run tests multiple times to ensure stability
4. Push your fix: This will reset the flap counter

If you need to proceed anyway:

• Fix the test flakiness first (recommended)
• Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

[posthog-bot]

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

• chromium: 0 added, 3 modified, 0 deleted (diff for shard 14, diff for shard 15)
• webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

[github-actions]

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

• playwright/__snapshots__/pageview-trends-insight.png

What this means:

• These screenshots are changing on each test run (timing issues, rendering differences, etc.)
• This prevents reliable verification and blocks auto-merge
• Human intervention is required

How to fix:

1. Investigate flakiness: Check test timing, wait for elements, stabilize animations
2. Fix the underlying issue: Don't just update snapshots repeatedly
3. Verify locally: Run tests multiple times to ensure stability
4. Push your fix: This will reset the flap counter

If you need to proceed anyway:

• Fix the test flakiness first (recommended)
• Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

[github-actions]

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

• playwright/__snapshots__/pageview-trends-insight.png

What this means:

• These screenshots are changing on each test run (timing issues, rendering differences, etc.)
• This prevents reliable verification and blocks auto-merge
• Human intervention is required

How to fix:

1. Investigate flakiness: Check test timing, wait for elements, stabilize animations
2. Fix the underlying issue: Don't just update snapshots repeatedly
3. Verify locally: Run tests multiple times to ensure stability
4. Push your fix: This will reset the flap counter

If you need to proceed anyway:

• Fix the test flakiness first (recommended)
• Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.