Skip to content

Conversation

@andrewjmcgehee
Copy link
Contributor

Problem

I didn't listen to Tom 😉

Items in the hog function template list are still filtered if the flag is undefined or resolves to false. This caused me to realize that we don't actually want to pass the flag in the template payload in the logic.

What we ACTUALLY want is to use the flag to determine whether a source is rendered as coming_soon or whether its rendered as available (beta or fully).

Changes

Remove flag from hog function template payload in logic. Use flag to determine whether the source is rendered as unreleased.

How did you test this code?

Ran locally.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Size Change: 0 B

Total Size: 3.34 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.34 MB

compressed-size-action

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

⚠️ Flapping Screenshots Detected

The following screenshots have been updated multiple times by the bot, indicating test instability:

  • playwright/__snapshots__/pageview-trends-insight.png

What this means:

  • These screenshots are changing on each test run (timing issues, rendering differences, etc.)
  • This prevents reliable verification and blocks auto-merge
  • Human intervention is required

How to fix:

  1. Investigate flakiness: Check test timing, wait for elements, stabilize animations
  2. Fix the underlying issue: Don't just update snapshots repeatedly
  3. Verify locally: Run tests multiple times to ensure stability
  4. Push your fix: This will reset the flap counter

If you need to proceed anyway:

  • Fix the test flakiness first (recommended)
  • Or manually verify snapshots are acceptable and revert the bot commits, then push a fix

The workflow has been failed to prevent merging unstable tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants