fix: feature flag editing state persisting after navigating #40765
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking to edit a feature flag and then navigating to another flag, the editing state was persisting, causing the new flag to incorrectly open in editing mode. This fix resets the editing state in the urlToAction handler when navigating via PUSH (clicking links), ensuring each flag starts with isEditingFlag=false unless explicitly set to edit mode. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
gustavohstrassburger
added
feature/feature-flags
![greptile-apps[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
Size Change: 0 B Total Size: 3.34 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When clicking to edit a feature flag and then navigating to another page, when navigating again to the original flag, it would still be in editing mode.
Changes
This fix resets the editing state in the urlToAction handler when navigating via PUSH (clicking links), ensuring each flag starts with isEditingFlag=false unless explicitly set to edit mode.
How did you test this code?
Manual