Skip to content

Conversation

@gustavohstrassburger
Copy link
Contributor

Changes

Add confirmation dialogs when deleting:

  • Cohorts (both detail and list pages)
  • Feature flags (both detail and list pages)

This prevents accidental deletion by requiring explicit user confirmation before proceeding with the deletion action.

How did you test this code?

Manual

Add confirmation dialogs when deleting:
- Cohorts (both detail and list pages)
- Feature flags (both detail and list pages)

This prevents accidental deletion by requiring explicit user confirmation
before proceeding with the deletion action.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@gustavohstrassburger gustavohstrassburger marked this pull request as ready for review October 31, 2025 20:37
@posthog-bot posthog-bot requested a review from a team October 31, 2025 20:37
@posthog-project-board-bot posthog-project-board-bot bot moved this to In Review in Feature Flags Oct 31, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Size Change: 0 B

Total Size: 3.34 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 3.34 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

@haacked haacked left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this from In Review to Approved in Feature Flags Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature/cohorts Feature Tag: Cohorts feature/feature-flags Feature Tag: Feature flags team/feature-flags

4 participants