feat: add validation to prevent deletion of cohorts in use #40761
+241
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent soft deletion of cohorts that are referenced in: - Test account filters (test_account_filters) - Active feature flags - Insights (query field) This ensures data integrity by blocking deletion of cohorts that are actively being used throughout the application. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
gustavohstrassburger
added
feature/cohorts
![greptile-apps[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
posthog/api/cohort.py
Outdated
Comment on lines
673
to
676
| insights_using_cohort = Insight.objects.filter( | ||
| team_id=cohort.team_id, | ||
| deleted=False, | ||
| ).filter(Q(query__icontains=f'"type": "cohort", "value": {cohort.id}')) |
There was a problem hiding this comment.
logic: This pattern won't detect cohorts used in breakdown filters. Insights can reference cohorts in breakdownFilter like {"breakdownFilter": {"breakdown_type": "cohort", "breakdown": [123]}}, which won't match this search pattern.
Consider also checking for:
"breakdown_type": "cohort"combined with the cohort ID in thebreakdownarray- Or use a more robust JSON traversal approach to find all cohort references
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/api/cohort.py
Line: 673:676
Comment:
**logic:** This pattern won't detect cohorts used in breakdown filters. Insights can reference cohorts in `breakdownFilter` like `{"breakdownFilter": {"breakdown_type": "cohort", "breakdown": [123]}}`, which won't match this search pattern.
Consider also checking for:
- `"breakdown_type": "cohort"` combined with the cohort ID in the `breakdown` array
- Or use a more robust JSON traversal approach to find all cohort references
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
It makes sense, submitting a new commit to fix this.
Add JSONB filter to detect cohorts used in insight breakdown filters. The previous implementation only checked properties filters, missing cohorts referenced in breakdownFilter.breakdown arrays. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If an user deletes cohorts that are used in insights or "Filter out internal and test users", those queries will fail.
Changes
Added validations to prevent deleting cohorts that are used in:
How did you test this code?
Manual
Unit tests