-
Notifications
You must be signed in to change notification settings - Fork 2k
feat(ph-ai): create experiments max tool #40753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 10-31-feat_ph-ai_create_multivariate_flags_max_tool
Are you sure you want to change the base?
feat(ph-ai): create experiments max tool #40753
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Size Change: 0 B Total Size: 3.34 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, 2 comments
| Examples: | ||
| - "Create an experiment to test the new checkout flow" | ||
| - "Set up an A/B test for our pricing page redesign" | ||
| - "Create an experiment called 'homepage-cta-test' to test different call-to-action buttons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
syntax: missing closing quote - will cause syntax error
| - "Create an experiment called 'homepage-cta-test' to test different call-to-action buttons | |
| - "Create an experiment called 'homepage-cta-test' to test different call-to-action buttons" |
Prompt To Fix With AI
This is a comment left during a code review.
Path: products/experiments/backend/max_tools.py
Line: 41:41
Comment:
**syntax:** missing closing quote - will cause syntax error
```suggestion
- "Create an experiment called 'homepage-cta-test' to test different call-to-action buttons"
```
How can I resolve this? If you propose a fix, please make it concise.| TODO_WRITE = "todo_write" | ||
| FILTER_REVENUE_ANALYTICS = "filter_revenue_analytics" | ||
| CREATE_FEATURE_FLAG = "create_feature_flag" | ||
| CREATE_EXPERIMENT = "create_experiment" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: posthog/schema.py is autogenerated by pnpm run schema:build and should not be manually modified. regenerate this file using the command instead of manual edits
Context Used: Rule from dashboard - Do not manually modify the posthog/schema.py file as it is autogenerated by the `pnpm run schema:b... (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: posthog/schema.py
Line: 285:285
Comment:
**style:** `posthog/schema.py` is autogenerated by `pnpm run schema:build` and should not be manually modified. regenerate this file using the command instead of manual edits
**Context Used:** Rule from `dashboard` - Do not manually modify the `posthog/schema.py` file as it is autogenerated by the `pnpm run schema:b... ([source](https://app.greptile.com/review/custom-context?memory=192de143-59d7-412f-bd71-fe5cb8f161dd))
How can I resolve this? If you propose a fix, please make it concise.16e71d9 to
e85e00d
Compare
4939dea to
3d8cb87
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |

Problem
This PR introduces a new
MaxToolto create experiments. It builds on top of thecreate_feature_flagMaxToolwith multivariate flag support.Changes
CreateExperimentToolthat allows creating experiments via PostHog AIHow did you test this code?
New tests + evals
Changelog: (features only) Is this feature complete?
Yes, this feature is complete and ready to be included in the changelog.