feat(migration-analyzer): flag DROP CONSTRAINT for deployment safety review #40742
+21
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…review Change DROP CONSTRAINT from score 1 (safe) to score 2 (needs review) to catch deployment safety issues. While the operation is instant (no table lock), dropping constraints can break running code during rolling deployments. Adds guidance about safe patterns: verify no code relies on constraint, deploy new constraints before dropping old ones, wait one deployment cycle. Aligns with existing patterns for dropping columns/tables and addresses scenarios like dropping UNIQUE constraints where code may not handle duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update migration analyzer to flag
DROP CONSTRAINToperations as score 2 (needs review) instead of score 1 (safe).While
DROP CONSTRAINTis technically instant (no table lock), it can break running code during rolling deployments. The analyzer should flag these for human review rather than auto-approving them.What changed
operations.py: Changed DROP CONSTRAINT from score 1 → 2Test plan
test_run_sql_drop_constraintto expect score 2