feat(ph-ai): remove stream processing from assistant class #40738
+841
−1,168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Size Change: 0 B Total Size: 3.34 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
kappa90
force-pushed
the
10-31-feat_ph-ai_remove_stream_processing_from_assistant_class
branch
from
41ef5dc to
885c396
Compare
kappa90
force-pushed
the
10-30-feat_ph-ai_move_stream_processor_outside_temporal
branch
from
96868e7 to
1aedf73
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To enable reusing the base assistant for Deep Research, we need to move the reducer/stream processor upstream, outside of Temporal, so that DR can call the agent using a ChildWorkflow and reducing the stream in a different way.
This is the third and last PR in a stack with the full change. Won't merge any PR in the stack until all are approved.
This PR has the full functionality and fixes all the tests
This PR refactors the Assistant API to use a more direct event streaming approach, simplifying the architecture by removing the intermediate event type layer, directly yielding
AssistantDispatcherEvent.Closes #12345
Changes
BaseAssistantto yield rawAssistantDispatcherEventobjects directly instead of wrapping them in event type tuplesAssistantGenerationStatusEventand related status event handling as it's not relevant anymoreAssistantSSESerializerto handle the new event structuremax_tools.pyAPI endpoint to use the new message formatHow did you test this code?
AssistantSSESerializerintest_sse.pytest_stream_processor.pyandtest_redis_stream.pyto work with the new event structure