Merged
Conversation
typhoonzero
reviewed
May 16, 2017
paddlecloud/paddlejob/views.py
Outdated
| import json | ||
|
|
||
| @login_required | ||
| def jobs_handler(request): |
Collaborator
There was a problem hiding this comment.
需要使用notebook/views.py中的SampleView作为样板，这样API调用可以使用token认证方式
paddlecloud/paddlejob/views.py
Outdated
| return utils.simple_response(500, str(e)) | ||
| return utils.simple_response(200, "OK") | ||
|
|
||
| def list_jobs(request): |
Collaborator
There was a problem hiding this comment.
list_jobs和delete_job还是展位接口吧？我可以提PR增加功能
paddlecloud/paddlejob/views.py
Outdated
| ) | ||
| try: | ||
| ret = client.ExtensionsV1beta1Api().create_namespaced_replica_set( | ||
| username, |
Collaborator
There was a problem hiding this comment.
namespace并不是直接用username，需要调用下email_escape函数
paddlecloud/paddlejob/views.py
Outdated
| #submit trainer job, it's Kubernetes Job | ||
| try: | ||
| ret = client.BatchV1Api().create_namespaced_job( | ||
| username, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #19