Skip to content

Add support for left + right on DismissSwipeDirection #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add support for left + right on DismissSwipeDirection #185

wants to merge 5 commits into from

Conversation

@darnfish
Copy link

@darnfish darnfish commented Aug 5, 2021 •
edited
Loading

What does this PR do?

  • Add support for .left and .right to DismissSwipeDirection
  • Add dismissOnRelease dismiss presented view on gesture ended (like a traditional UIViewController)
  • Uses swipedAmount > 50% of VC rather than swipeLimit = 100
    • Also adds support for velocity-based dismissal, for when you quickly swipe the view away, but don't make it to the 50% limit
  • Add support for overdragResistanceFactor (see Need elastic resistance when swiping in opposite direction to dismiss #163)
@darnfish
Copy link
Author

darnfish commented Aug 5, 2021

Lol I did not see #182 before making this, still keeping open as this PR provides some extra features :~) but it seems like the maintainer is not active
@darnfish darnfish changed the title Add support for left + right dismissOnSwipeDirection Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@darnfish