Default fonts are changed to system fonts. #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 21, 2018 14:43
Forcing to use custom fonts and huge code-base are unnecessary. It looks great now. 🤙🏼
|
This might look like a small change but it’s very welcome in my opinion. I’d risk to say most projects stay with the default system fonts unless they have an extremely stylized design. Having the library default to a font that has nothing to do with most projects just adds unneeded complexity to an otherwise very accessible library. Sent with GitHawk |
|
Agreed. This is a good change. Will test and merge ASAP. |
|
@danlozano This is a great change. Can you merge this PR or give another collaborator rights to merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forcing to use custom fonts and huge codebase are unnecessary. So, I deleted custom fonts then removed unnecessary lines for loading custom fonts that comes with library.